Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discovery module 2.3 ready #604

Merged
merged 4 commits into from
May 24, 2024
Merged

Make discovery module 2.3 ready #604

merged 4 commits into from
May 24, 2024

Conversation

Max-checkmk
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #587

  • New options for Bulk discovery aren't implemented
  • tabula_rasa doesn't work

What is the new behavior?

  • Discovery module is now 2.3 ready
  • Discovery module has now 2 new options for 2.3 -> update_service_labels and monitor_undecided_services
  • It's possible to use tabula_rasa again (does the same as refresh)

Other information

@Max-checkmk Max-checkmk added the module:discovery This affects the discovery module label May 22, 2024
@Max-checkmk Max-checkmk self-assigned this May 22, 2024
@Max-checkmk Max-checkmk linked an issue May 23, 2024 that may be closed by this pull request
[BUG] discovery module out of sync with the Checkmk REST API #587
Closed
@Max-checkmk Max-checkmk added enhancement New feature or request release:5.0.0 Affects the mentioned release. labels May 23, 2024
@robin-checkmk robin-checkmk merged commit e6aaacb into build/checkmk-2-3-support May 24, 2024
8 checks passed
@robin-checkmk robin-checkmk deleted the 2.3ready-discovery-module branch May 24, 2024 12:15
@robin-checkmk robin-checkmk mentioned this pull request May 24, 2024
Merged
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgetwan lgetwan Awaiting requested review from lgetwan

@robin-checkmk robin-checkmk Awaiting requested review from robin-checkmk

Assignees

@Max-checkmk Max-checkmk

Labels
enhancement New feature or request module:discovery This affects the discovery module release:5.0.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] discovery module out of sync with the Checkmk REST API
2 participants
@Max-checkmk @robin-checkmk