Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: integration test for preprocess+evaluate #161

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Feb 20, 2024

A follow-up for #160. The new test fails with the following error when the fix from #160 is not applied - notice that result_rate_IPNI_NOT_QUERIED is 1 and all other results have a rate 0:

   "inet_groups": "967i"
   "measurements": "7956i"
   "participants": "2067i"
   "rate_of_deals_advertising_http": "0.054"
-  "result_rate_BAD_GATEWAY": "0"
+  "result_rate_BAD_GATEWAY": "0.017722473604826545"
   "result_rate_CAR_TOO_LARGE": "0"
   "result_rate_GATEWAY_TIMEOUT": "0"
-  "result_rate_IPNI_NOT_QUERIED": "1"
-  "result_rate_OK": "0"
+  "result_rate_IPNI_ERROR_404": "0.8329562594268477"
+  "result_rate_IPNI_ERROR_FETCH": "0.0007541478129713424"
+  "result_rate_OK": "0.033308195072900955"
   "result_rate_TIMEOUT": "0"
+  "result_rate_UNKNOWN_ERROR": "0.1152589240824535"
   "round_index": "1255i"
-  "success_rate": "0"
+  "success_rate": "0.033308195072900955"
   "tasks_per_node_max": "15i"
   "tasks_per_node_mean": "1i"
   "tasks_per_node_min": "1i"
   "tasks_per_node_p1": "1i"

Links:

@bajtos bajtos requested a review from juliangruber February 20, 2024 12:33
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 👏 👏

@bajtos bajtos merged commit bf0a16f into main Feb 20, 2024
5 checks passed
@bajtos bajtos deleted the integration-test branch February 20, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants