Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SubmittableDeal type #95

Merged
merged 3 commits into from
Feb 13, 2025
Merged

add SubmittableDeal type #95

merged 3 commits into from
Feb 13, 2025

Conversation

NikolasHaimerl
Copy link
Contributor

We are currently not using a specific type when submitting deals through the deal observer backend.
In two recent discussions (Here and here), the need for a specific type for submittable deals has come up.

This PR suggests a new type for deals that are found to be submittable and used throughout the submitting process of the deal observer.
This solves the issue of the use of the any type when activating type checking and also delivers clarity on the type returned by various functions during the submitting process.

@NikolasHaimerl NikolasHaimerl marked this pull request as ready for review February 11, 2025 09:39
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal in this pull request is consistent with what we are doing elsewhere in this project, I don't see any obvious issues besides one minor comment below.

Copy link
Contributor

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve type signature to make it simple and more correct.

Copy link
Contributor

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👏🏻

@NikolasHaimerl NikolasHaimerl enabled auto-merge (squash) February 13, 2025 08:19
@NikolasHaimerl NikolasHaimerl merged commit c71358e into main Feb 13, 2025
9 checks passed
@NikolasHaimerl NikolasHaimerl deleted the nhaimerl-submittable-deal branch February 13, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants