-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SubmittableDeal type #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposal in this pull request is consistent with what we are doing elsewhere in this project, I don't see any obvious issues besides one minor comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can improve type signature to make it simple and more correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👏🏻
We are currently not using a specific type when submitting deals through the deal observer backend.
In two recent discussions (Here and here), the need for a specific type for submittable deals has come up.
This PR suggests a new type for deals that are found to be submittable and used throughout the submitting process of the deal observer.
This solves the issue of the use of the any type when activating type checking and also delivers clarity on the type returned by various functions during the submitting process.