Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing graphsync test. #110 #111

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

juliangruber
Copy link
Member

For #110

Unbreak the test suite by disabling the failing test.

@bajtos what do you advise here? Shall we find another provider (if so, how? The top SP from the RSR list?), or keep this test disabled?

@juliangruber juliangruber requested a review from bajtos as a code owner February 18, 2025 10:24
@juliangruber juliangruber merged commit 6ff24e1 into main Feb 18, 2025
2 checks passed
@juliangruber juliangruber deleted the fix/disable-failing-graphsync-test branch February 18, 2025 10:25
@bajtos
Copy link
Member

bajtos commented Feb 21, 2025

@bajtos what do you advise here? Shall we find another provider (if so, how? The top SP from the RSR list?), or keep this test disabled?

I think it's important to re-enable this test. Otherwise, Graphsync retrievals can silently break, and we won't notice until an SP complains about their RSR dropping to zero.

You can look at the top SPs on our dashboard, maybe find one with low HTTP-RSR but high RSR - that means they are serving Graphsync retrievals.

You can find payload CIDs stored with them by manually querying spark-api's eligible_deals table.

I have had an idea how to make it easier to sample payload CIDs for a given miner, but never found time to implement it: Enhance the endpoint returning a summary of eligible deals to also return a random sample of payload CIDs. See
https://github.com/CheckerNetwork/spark-api/blob/82941b9c4dcc4316ee41579b985890cd9768c4de/api/index.js#L313-L322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants