Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redundant exit message #551

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix redundant exit message #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/zinnia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ const catchChildProcessExit = async ({
const tasks = childProcesses.map(p => (async () => {
try {
await p
onActivity({ type: 'info', message: `${capitalize(module)} exited` })
} catch (err) {
// When the child process crash, attach the module name & the exit reason to the error object
const exitReason = p.exitCode
Expand Down Expand Up @@ -294,12 +295,6 @@ export async function run ({
resetTimeout()
process.stderr.write(data)
})

childProcess.on('exit', (code, signal) => {
const exitReason = signal ? `via signal ${signal}` : `with code: ${code}`
const msg = `${capitalize(module)} exited ${exitReason}`
onActivity({ type: 'info', message: msg })
})
}

try {
Expand Down
Loading