feat: Generate + store station_id keypair and pass to Zinnia via env var

[PatrickNercessian]

Links:
CheckerNetwork/roadmap#96

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	Transitive: environment, filesystem, network, shell	+38	1.25 MB	shiftkey

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

[juliangruber]

Great work so far, @PatrickNercessian! 👏

[bajtos]

@PatrickNercessian would you mind adding Station ID to the ping telemetry points?

https://github.com/filecoin-station/core/blob/f8fd023d90715202ef5d23d253776b8036ee6456/lib/telemetry.js#L52-L56

Proposed change in commands/station.js

-  startPingLoop().unref()
+  startPingLoop({ STATION_ID }).unref()

[bajtos]

LGTM 👍🏻

@juliangruber: Could you please check the new keytar interaction when both Desktop and Core read from the keychain at startup?

[juliangruber]

Tested and works 👍

[bajtos]

@SocketSecurity ignore npm/[email protected]

[bajtos]

The builds are failing on Linux now.

[Error: The name org.freedesktop.secrets was not provided by any .service files]

node:internal/modules/cjs/loader:1465
  return process.dlopen(module, path.toNamespacedPath(filename));
                 ^

Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
    at Module._extensions..node (node:internal/modules/cjs/loader:1465:18)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/usr/src/app/node_modules/keytar/lib/keytar.js:1:14)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12) {
  code: 'ERR_DLOPEN_FAILED'
}

[bajtos]

I added 0fe59a9 to install libsecret required by node-tar.

We are getting a different error now:

[Error: Object does not exist at path “/org/freedesktop/secrets/collection/login”]

@PatrickNercessian could you please look into this yourself?

Maybe we can copy the setup steps from keytar's CI, see the following two blocks:

• https://github.com/atom/node-keytar/blob/deae59a488789f2cd4a8dba6c7e58665795804fe/.github/workflows/ci.yml#L39-L45
• https://github.com/atom/node-keytar/blob/deae59a488789f2cd4a8dba6c7e58665795804fe/.github/workflows/ci.yml#L62-L73

That code is more than two years old; there may be easier options available by now. Feel free to use a different approach to fix this problem!

[juliangruber]

See PatrickNercessian#1