-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Zinnia Runtime and Peer Checker module #92
Conversation
Add another post-install step to download `zinniad` for running Zinnia modules. Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
over to me 😏
It seems the Ubuntu Docker images are coming in minimal flavour by default, so hopefully there won't be too much bloat introduced by switching from Alpine to Debian 🤞🏻 https://canonical.com/blog/minimal-ubuntu-released
https://hub.docker.com/_/ubuntu
|
Co-authored-by: Julian Gruber <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
This reverts commit 11a56e7.
Signed-off-by: Miroslav Bajtoš <[email protected]>
I'll debug it on my Windows machine 👍 Basically for anything Windows specific you can defer that to me, as the team budget bought my Thinkpad. |
And if you need to sit at the machine, because it's more complicated etc, I'm happy to start the machine and give you remote access |
|
Perfect, thank you for stepping in and fixing the issue! Windows tests are passing on most versions, but there is a timeout on Node.js 16.
I'll re-run the test to see if this is intermittent. It would be nice to make our tests more robust, but I'd rather leave that out of this PR. |
Agreed, mostly I just re-run these but a better fix would be great |
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
@juliangruber I added three more commits to make the tests more robust, easier to troubleshoot and less prone to timing errors. PTAL at the changes and also let me know if I should extract those three commits into a standalone PR. |
One of my commits wasn't signed, which paused auto merging. Sorry about that! |
feat: install Zinnia runtime
feat: install mod-peer-checker
feat: run peer checker module via Zinnia
feat: switch base Docker image to full
node:18
test: move mocha config to config file and add
--exit
test: make
test/station.js
easier to troubleshoottest: fix expected Saturn messages
See CheckerNetwork/zinnia#75
TODO
main
feat: build binary for aarch64-unknown-linux-gnu zinnia#172
Out of Scope
Access logs of individual Zinnia modules. It's tricky! I'll create a follow-up issue for that.
Documentation for Core developers