fix: special shortcut for Windows live notifications #5975
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@Nerixyz there might be a bug with pinning c2 to the taskbar. Steps
-> Tested the Taskbar shortcut, and it don't include the AUMI Questions: |
| settings.append(this->createCheckBox( | ||
| "Create start menu shortcut (requires " | ||
| "restart)", | ||
| getSettings()->createShortcutForToasts, | ||
| "When enabled, a shortcut will be created inside your " | ||
| "start menu folder if needed by live notifications." | ||
| "\n(On portable mode, this is disabled by " | ||
| "default)")); |
There was a problem hiding this comment.
You can use SettingWidget here, which means you wouldn't have to update the createCheckBox implementation - see
chatterino2/src/widgets/settingspages/GeneralPage.cpp
Lines 1231 to 1235 in 7fee3f7
| @@ -526,6 +527,9 @@ class Settings | |||
| "/notifications/suppressInitialLive", false}; | |||
|
|
|||
| BoolSetting notificationToast = {"/notifications/enableToast", false}; | |||
| BoolSetting createShortcutForToasts = { | |||
| "/notifications/createShortcutForToasts", | |||
| Modes::instance().isPortable ? false : true}; | |||
There was a problem hiding this comment.
add a , at the end of the ternary, that way it formats a bit nicer, causing nicer diffs in the future if we have to edit it
Fixes #5954