-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eventsub): add operator== and indicator for shared chat #5974
Conversation
i don't think we do this in pubsub, but maybe we could add this suffix to the moderation messages: e.g., sharedMod banned badGuy for the duration of the shared chat session |
After claryfing with @iProdigy - moderation actions that happen in the other room during a shared chat session do take effect in your chat, so I think it would make sense to show them still, but maybe with an extra piece of text attached to it like they mentioned above |
There's little to no documentation on this well-thought-out feature. Do emoteonly and friends apply as well? Also, what's the purpose of having |
yeah i agree it's not adequately explained in the dev docs the user facing docs do explain it with a complicated table https://link.twitch.tv/SharedChatMod also ive written my own explainer at https://twitch4j.github.io/chat/shared-chat/ back to your question: roomstate does not apply to other channels, neither do automod settings or blocked/permitted terms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
sorry if i wasn't clear earlier: we only have to annotate (un)ban/(un)timeout - warn/(un)mod/(un)timeout/(un)raid/etc are not mirrored (and |
... so this is a mistake in the docs? The |
yeah believe that's a docs error (for eventsub; in pubsub it is mirrored) |
Thank you for clarifying. tl;dr: anything, but the
|
To not confuse moderators, we should ignore moderation events when using shared chat (I believe that's what we're implicitly doing in PubSub as well).