Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eventsub): add operator== and indicator for shared chat #5974

Merged
merged 6 commits into from
Feb 22, 2025

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Feb 22, 2025

To not confuse moderators, we should ignore moderation events when using shared chat (I believe that's what we're implicitly doing in PubSub as well).

@iProdigy
Copy link
Contributor

i don't think we do this in pubsub, but maybe we could add this suffix to the moderation messages: for the duration of the shared chat session

e.g., sharedMod banned badGuy for the duration of the shared chat session

@pajlada
Copy link
Member

pajlada commented Feb 22, 2025

After claryfing with @iProdigy - moderation actions that happen in the other room during a shared chat session do take effect in your chat, so I think it would make sense to show them still, but maybe with an extra piece of text attached to it like they mentioned above

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Feb 22, 2025

moderation actions that happen in the other room during a shared chat session do take effect in your chat,

There's little to no documentation on this well-thought-out feature. Do emoteonly and friends apply as well? Also, what's the purpose of having shared_chat_* then?

@iProdigy
Copy link
Contributor

yeah i agree it's not adequately explained in the dev docs

the user facing docs do explain it with a complicated table https://link.twitch.tv/SharedChatMod

also ive written my own explainer at https://twitch4j.github.io/chat/shared-chat/

back to your question: roomstate does not apply to other channels, neither do automod settings or blocked/permitted terms

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@iProdigy
Copy link
Contributor

sorry if i wasn't clear earlier: we only have to annotate (un)ban/(un)timeout - warn/(un)mod/(un)timeout/(un)raid/etc are not mirrored (and shared_chat_delete is a legit deletion, so no suffix needed for that either)

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Feb 22, 2025

warn/(un)mod/(un)timeout/(un)raid/etc are not mirrored

... so this is a mistake in the docs? The warn example here shows different users in broadcaster vs source.

@iProdigy
Copy link
Contributor

iProdigy commented Feb 22, 2025

yeah believe that's a docs error (for eventsub; in pubsub it is mirrored)

@Nerixyz Nerixyz changed the title fix(eventsub): ignore moderation events from shared chat chore(eventsub): add operator== and indicator for shared chat Feb 22, 2025
@Nerixyz
Copy link
Contributor Author

Nerixyz commented Feb 22, 2025

Thank you for clarifying. tl;dr: anything, but the shared_* events aren't mirrored.

operator== is still a useful feature, same as isSharedChat (maybe we need that for the shared-chat events).

@pajlada pajlada merged commit 7fee3f7 into Chatterino:master Feb 22, 2025
16 checks passed
@Nerixyz Nerixyz deleted the fix/ignore-shared-chat branch February 22, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants