fix(eventsub/string): minor cleanups #5973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5968.
std::string_view
constexpr, because we can store aQString
which isn't constexpr → our destructor isn't constexpr.view()
can be constexpr (not sure what the use is)length
was never usedstd::mem*
functions tovoid*
explicitly - otherwise, it warns that the type isn't trivially copyable. It doesn't know that (1) we're moving and (2)QString
is trivially relocatable (memcpy-able).QString
is actually destructed (similar to chore(tests): try to generate coverage better #5972).