Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build universal binary for macos #3711

Merged
merged 5 commits into from
Feb 6, 2024
Merged

ci: build universal binary for macos #3711

merged 5 commits into from
Feb 6, 2024

Conversation

shirok1
Copy link
Contributor

@shirok1 shirok1 commented Dec 30, 2023

Closes #2247

@shirok1 shirok1 mentioned this pull request Dec 30, 2023
Closed
@shirok1 shirok1 marked this pull request as draft December 30, 2023 15:25
@shirok1
Copy link
Contributor Author

shirok1 commented Dec 30, 2023

会干扰 dtolnay/rust-toolchain 下载工具链，稍等

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

It will interfere with dtolnay/rust-toolchain downloading the toolchain, please wait.

@shirok1 shirok1 marked this pull request as ready for review December 30, 2023 15:50
@shirok1
Copy link
Contributor Author

shirok1 commented Jan 3, 2024

@fredliang44 请考虑手动触发该 action 以进行测试

@Yidadaa
Copy link
Collaborator

Yidadaa commented Jan 10, 2024

@shirok1 请问是否自测过该功能？

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

@shirok1 Have you tested this function yourself?

@shirok1
Copy link
Contributor Author

shirok1 commented Jan 10, 2024

正在测试 https://github.com/shirok1/ChatGPT-Next-Web/actions/runs/7476755442

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

Testing https://github.com/shirok1/ChatGPT-Next-Web/actions/runs/7476755442

@shirok1
Copy link
Contributor Author

shirok1 commented Jan 10, 2024

@Yidadaa 目前看来没有问题，最后是因为无法上传而失败
多加了一些修改，合并的时候 squash 了吧

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

@Yidadaa There seems to be no problem at the moment, but in the end it failed because it could not be uploaded.
I added some more modifications and squashed them when merging.

@shirok1
Copy link
Contributor Author

shirok1 commented Jan 12, 2024

@Yidadaa

1 similar comment
@shirok1
Copy link
Contributor Author

shirok1 commented Jan 17, 2024

@Yidadaa

@fred-bf fred-bf merged commit deea432 into ChatGPTNextWeb:main Feb 6, 2024
1 check failed
shirok1 added a commit to shirok1/cinny-desktop that referenced this pull request Feb 15, 2024
@shirok1
ci: build universal binary for macos
9443a7d 
reference: ChatGPTNextWeb/NextChat#3711
@shirok1 shirok1 mentioned this pull request Feb 15, 2024
Closed
9 tasks
gaogao1030 pushed a commit to gaogao1030/ChatGPT-Next-Web that referenced this pull request May 16, 2024
@shirok1
ci: build universal binary for macos (ChatGPTNextWeb#3711)
d2a91ee 
* ci: build universal binary for macos

* ci: add tauri args

* ci: restore rust_target

* ci: fallback value for tauri build args

* ci: cache yarn
@kfiven kfiven mentioned this pull request Jun 6, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] macOS x86_64 和 aarch64 产生的artifacts名称相同，会互相覆盖
4 participants
@shirok1 @Issues-translate-bot @Yidadaa @fred-bf