-
Notifications
You must be signed in to change notification settings - Fork 60.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 微信 Android 内置浏览器兼容性 #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues in browsers like WeChat where the encoding is incorrect and the summary feature does not work if it contains zh-CN characters.
Also avoid using Array.prototype.at, which does not seem to exist in the Wexin builtin webview (Android Wexin 8.0.30).
Someone is attempting to deploy a commit to a Personal Account owned by @Yidadaa on Vercel. @Yidadaa first needs to authorize it. |
请尝试增加一个 Array.at 的 polyfill 来解决 .at 的兼容性问题,因为 js 中直接取数组下标的方式是类型不安全的。 |
This fixes compatibility issue with older browsers like WeChat webview. The summary feature now works as expected.
Array.at 问题在微信浏览器外也会出现 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
这个 pr 让产物的大小从 100kb 上升到了 111kb,需要删掉引入的三方库,手动实现 polyfill |
yxl
pushed a commit
to yxl/ChatGPT-Next-Web
that referenced
this pull request
May 4, 2023
fix: 微信 Android 内置浏览器兼容性
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
微信 Android 版本 8.0.30
主要有两个问题:
Array.at
不存在Content-Type
未设,有可能导致 openai api 返回中文时解析为乱码这些问题主要影响话题总结功能,具体表现为 AI 回复后标题仍为默认标题。