Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant export #3087

Closed
wants to merge 1 commit into from
Closed

remove redundant export #3087

wants to merge 1 commit into from

Conversation

dvtate
Copy link

@dvtate dvtate commented Oct 24, 2023

No description provided.

@dvtate
Copy link
Author

dvtate commented Oct 24, 2023

also why are all the messages being copied in the chat method? seems pointless

@H0llyW00dzZ
Copy link
Contributor

H0llyW00dzZ commented Oct 24, 2023

@dvtate for filtering a messages response
it's not actually pointless as you think if you adding for other models which is response only json

@dvtate
Copy link
Author

dvtate commented Oct 24, 2023

@H0llyW00dzZ ok that makes sense we don't want to send the extra data in our request. Still the export at the end of the file is never used in the project and makes no sense as one should import it from elsewhere

@H0llyW00dzZ
Copy link
Contributor

@dvtate might the owner forgot to removed it, or was used for some function before. (eg in old version)

@dvtate
Copy link
Author

dvtate commented Oct 24, 2023

sure, either way, not needed anymore

@H0llyW00dzZ
Copy link
Contributor

H0llyW00dzZ commented Oct 24, 2023

auto link pr : #1917

image

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


auto link pr : #1917
image

@dvtate
Copy link
Author

dvtate commented Oct 25, 2023

that export never used

@Yidadaa Yidadaa closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants