fix: the row number counting logic of the textarea #1359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr introduces a new bug, single Enter should grow the textarea. |
|
|
|
I will submit a pr later to fix it. |
Yidadaa
added a commit
that referenced
this pull request
May 9, 2023
This was referenced May 10, 2023
Merged
|
hope my new PR can address the issues in both my previous PR and yours. |
Endlessworld
pushed a commit
to Endlessworld/ChatGPT-Next-Web
that referenced
this pull request
May 17, 2023
Endlessworld
pushed a commit
to Endlessworld/ChatGPT-Next-Web
that referenced
this pull request
May 17, 2023
feat: ChatGPTNextWeb#1055, ChatGPTNextWeb#444 and fix ChatGPTNextWeb#1359 hot key to switch chat and allow to disable gpt-4
jinker
pushed a commit
to jinker/ChatGPT-Next-Web
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as in the snapshot, if you input some content (in my example i used
111) with a line breaker for each line, you can find the row num of the textarea increases too many, resulting a tall blank area under the cursor point. I checked the logic, finding actually it only needs to add 1 to the total row number only if the user's input is ending with\n.