Refine ERC20, ERC721, ERC1155 utility classes #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ripts and added corresponding built-in contracts (ErcXXContract) and services (ErcXXService) to the core solution. Introduced IpfsHelper.
auto-assign
bot
requested review from
juans-chainsafe,
kantagara,
rob1997 and
sneakzttv
juans-chainsafe
suggested changes
May 13, 2024
There was a problem hiding this comment.
I run the setup.sh but Im getting the following build errors:
Library/PackageCache/com.tools.webglthreadingpatcher@c2f3628a02/ThreadingPatcher/Editor/WebGLThreadingPatcher.cs(21,38): error CS1061: 'BuildReport' does not contain a definition for 'GetFiles' and no accessible extension method 'GetFiles' accepting a first argument of type 'BuildReport' could be found (are you missing a using directive or an assembly reference?)
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc721Tests.cs(48,28): error CS0103: The name 'Erc721' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc721Tests.cs(56,26): error CS0103: The name 'Erc721' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc721Tests.cs(64,31): error CS0103: The name 'Erc721' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc721Tests.cs(72,19): error CS0103: The name 'Erc721' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc1155Tests.cs(30,28): error CS0103: The name 'Erc1155' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc1155Tests.cs(38,28): error CS0103: The name 'Erc1155' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc1155Tests.cs(49,19): error CS0103: The name 'Erc1155' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmCustomResponseTests.cs(139,22): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmTests.cs(110,84): error CS0103: The name 'EthMethod' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmCustomResponseTests.cs(150,23): error CS0103: The name 'Erc721' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmCustomResponseTests.cs(161,24): error CS0103: The name 'Erc1155' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmCustomResponseTests.cs(172,29): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmCustomResponseTests.cs(183,30): error CS0103: The name 'Erc721' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmTests.cs(152,34): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/EvmCustomResponseTests.cs(194,31): error CS0103: The name 'Erc1155' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc1155Tests.cs(129,23): error CS0103: The name 'Erc1155' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc20Tests.cs(30,28): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc20Tests.cs(38,34): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc20Tests.cs(46,27): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc20Tests.cs(54,23): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc20Tests.cs(62,25): error CS0103: The name 'Erc20' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Tests/Runtime/Erc20Tests.cs(70,30): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(43,29): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(44,65): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(44,80): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(75,19): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(76,21): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(77,65): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(77,82): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(52,28): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(53,64): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(53,79): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(61,28): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(62,64): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(62,79): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(85,30): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(87,61): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(87,78): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(70,28): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(71,53): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(71,68): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(95,25): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(96,50): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(96,67): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(69,29): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(70,65): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(70,81): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(79,28): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(80,53): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(80,68): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(104,30): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(106,53): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(106,70): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(88,30): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(89,66): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(89,81): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(114,30): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(116,53): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(116,70): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(97,28): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(98,64): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(98,79): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs(124,36): error CS0103: The name 'Erc1155' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(106,30): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(108,53): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(108,68): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(116,30): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(118,53): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc20/Erc20Calls.cs(118,68): error CS0103: The name 'Erc20' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(81,19): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(82,21): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(83,52): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(83,68): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(91,28): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(102,70): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(102,86): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(110,25): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(111,50): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(111,66): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(119,30): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(121,53): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(121,69): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(129,30): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(131,53): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc721/Erc721Calls.cs(131,69): error CS0103: The name 'Erc721' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/EVM/EvmCalls.cs(217,98): error CS0103: The name 'EthMethod' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/EVM/EvmCalls.cs(329,61): error CS0103: The name 'EthMethod' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/EVM/EvmCalls.cs(334,63): error CS0103: The name 'EthMethod' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/EVM/EvmCalls.cs(360,57): error CS0103: The name 'EthMethod' does not exist in the current context
Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/EVM/EvmCalls.cs(366,59): error CS0103: The name 'EthMethod' does not exist in the current context
Without the setup.sh I only get these: |
Added shortcut methods to call smart-contract methods directly from a service without building a contract manually Added Erc20/721/1155 services as default ones for Web3
…eksandr/refine-erc-xx # Conflicts: # src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scenes/SampleMain.unity
|
@juans-chainsafe Forgot to make the PR draft. It just was not ready for testing. Now it is. |
kantagara
approved these changes
May 14, 2024
juans-chainsafe
suggested changes
May 15, 2024
There was a problem hiding this comment.
@oleksandrchainsafe Most of the samples are working, the only one failing is the "ImportNftTexture" with this error:
Web3Exception: Metadata request failure:
Scripts.EVM.Token.Erc1155UnityExtensions.ImportTexture (ChainSafe.Gaming.Evm.Contracts.BuiltIn.Erc1155Contract contract, System.String tokenId) (at /Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/EVM/Token/Erc1155UnityExtensions.cs:24)
Erc1155Calls.ImportNftTexture1155 () (at Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/Erc1155/Erc1155Calls.cs:137)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) (at <b6c5d0f08ddf477186f780f49bb14dee>:0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:153)
UnityEngine.UnitySynchronizationContext.Exec () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:83)
UnityEngine.UnitySynchronizationContext.ExecuteTasks () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:107)
Is working in dev branch
rob1997
approved these changes
May 17, 2024
juans-chainsafe
approved these changes
May 17, 2024
|
@juans-chainsafe I don't understand how this works in dev, because the URI of the NFT is not reachable on my end (might be antivirus issue). For token with id "0", i get this URI https://ipfs.chainsafe.io/ipfs/QmfUHuFj3YL2JMZkyXNtGRV8e9aLJgQ6gcSrqbfjWFvbqQ. It is not accessible through a browser on my end. Try it on yours pls. @sneakzttv Do you know why it works in dev, but when I try to access URI of the same NFT in this branch, it fails? We're accessing the NFT with ID "0" and contract address "0xAA2EbE78aa788d13AfFaaefD38C93333bbC4d51e" right? |
Serialized variables im guessing, probably different. That url is down also, which function is it on? |
It's |
|
works now, congestion perhaps metadata: https://ipfs.chainsafe.io/ipfs/QmfUHuFj3YL2JMZkyXNtGRV8e9aLJgQ6gcSrqbfjWFvbqQ |
|
we're going to have to majorly change the docs again xD |
sneakzttv
approved these changes
May 21, 2024
juans-chainsafe
approved these changes
May 21, 2024
There was a problem hiding this comment.
URI sample now is working in the editor ✅
But when you try to login in a WebGL build it fails:
Web3Exception: Resource ChainSafe.Gaming.Resources.erc-20-abi.json not found in the provided assembly.
at ChainSafe.Gaming.Evm.Utils.AbiHelper.ReadAbiFromResources (System.Reflection.Assembly assembly, System.String resourceName) [0x00000] in <00000000000000000000000000000000>:0
--- End of stack trace from previous location where exception was thrown ---
juans-chainsafe
suggested changes
May 21, 2024
Created this ticket for this issue #966 |
|
= seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Added the ability to copy webgl templates directly trough our Chainsafe SDK menu.
|
@juans-chainsafe should be fixed. Closes #966 |
juans-chainsafe
suggested changes
May 28, 2024
There was a problem hiding this comment.
For some reason the sample "CustomTokenBalance" is not logging anything in the console, I tried a development build as well but I dont see any logs. I remember this was working in the first version that I tested.
I checked with WebGL and editor.
Everything else is working as expected.
juans-chainsafe
approved these changes
May 28, 2024
|
closes #952 |
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Removed static Erc20, Erc721, Erc1155 utility classes from package scripts and added corresponding built-in contracts (ErcXXContract) and services (ErcXXService) to the core solution. Introduced IpfsHelper. * Added contract caching for Erc20/721/1155 services. Added shortcut methods to call smart-contract methods directly from a service without building a contract manually Added Erc20/721/1155 services as default ones for Web3 * Updated Erc20/Erc721/Erc1155 usage samples * Removed Custom Token Balance sample button * Erc1155 ImportTexture fix * Erc1155 ImportTexture fix * Fixing merging error * Fixing compiler errors * Proper contract addresses * Fixed issue with WebGL not recognizing embedded resources. Added the ability to copy webgl templates directly trough our Chainsafe SDK menu. * Removed Custom Token Balance --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Juan Manuel Spoleti <[email protected]> Co-authored-by: = <=> Co-authored-by: Nikola Garabandic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed static Erc20, Erc721, Erc1155 utility classes from package scripts and added corresponding built-in contracts (ErcXXContract) and services (ErcXXService) to the core solution.
Introduced IpfsHelper.
Closes #937 , #966