Marketplace API sample calls #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
juans-chainsafe,
kantagara,
oleksandrchainsafe and
rob1997
sneakzttv
added
the
ready-to-merge
sneakzttv
added
ready-to-merge
kantagara
approved these changes
May 8, 2024
juans-chainsafe
approved these changes
May 8, 2024
|
|
||
| #region Collections | ||
|
|
||
| [SerializeField] private string collectionId721 = "d588268b-8a5b-486a-8ea1-4122b510d71e"; |
There was a problem hiding this comment.
I wonder if we can set these values on the editor inspector, so testing is quicker. I also think that should be blank by default, because they will only work for the owner
There was a problem hiding this comment.
we can, ill do this in another pr though
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Marketplace api calls functional * Cleanup * Abstraction layer * Update CSServer.cs * Updates * Serialized fields * Abstraction * Cleanup * Update * Update .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace api sample get calls working on sepolia in the sample scene following the api docs here:
https://docs.gaming.chainsafe.io/marketplace-api/docs/marketplaceapi
https://docs.gaming.chainsafe.io/token-api/docs/tokenapi
Smaller commits so it's not a large shock later, WIP #912
Additional misc fixes:
DisableGameObjectIfServiceNotActive.cs was returning a non existent dictionary key, added a try get value to make sure it exists first to avoid errors.
Cleaned up old model scripts.