-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UnitySampleProject to 2022 LTS #938
Update UnitySampleProject to 2022 LTS #938
Conversation
@juans-chainsafe Please "Ensure all features are working as before across all platforms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt finish the whole testing, but this is the feedback so far:
- Editor with web3auth + samples + logout + remember me ✅
- Editor with wallet connect + samples + logout + remember me ✅
- Isolated Lootbox scene (without login) in editor ✅
- WebGL with metamask login + samples + logout ✅
❌ Issues:
- Ramp is not working in WebGL, neither metamask login or web3auth, loading spinner is stuck in a loop:
- Samples that require sign a transaction like GetNonce, Mint or Transfer in WebGL with web3auth:
Invoking error handler due to
RuntimeError: null function or function signature mismatch
Stuff that I can't test due to previous errors:
- Countly Countly not working in WebGL with Package manager #880
- 3 of the Gelato samples Some Gelato calls are cancelled #881
PENDING:
- iOS with web3auth
- iOS with wallet connect
- Empty Unity project from scratch
iOS testing:
@oleksandrchainsafe weird thing is that Ramp is working in iOS but not in WebGL. And samples that require a transaction works in iOS + web3auth but they DON'T work in WebGL + web3auth |
@juans-chainsafe could you check |
Ramp issue on WebGL can be solved by following steps here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebGL + Web3Auth issue was fixed with #963
So, we are good to go!
Updated UnitySampleProject version to 2022.3.26f1 Co-authored-by: oleksandr <[email protected]> Co-authored-by: Nikola Garabandic <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: Juan Manuel Spoleti <[email protected]>
Updated to 2022.3.26f1