Package built-in dependencies fix #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrchainsafe
requested review from
kantagara,
rob1997,
sneakzttv and
juans-chainsafe
kantagara
previously approved these changes
Apr 23, 2024
|
This should target |
rob1997
added
the
ready-to-merge
rob1997
approved these changes
Apr 23, 2024
rob1997
added
ready-to-merge
juans-chainsafe
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Working, I didnt find build errors, i checked WebGL and iOS as well just in case.
I did it using this document https://www.notion.so/chainsafe/Simulating-OpenUPM-scenario-locally-16ac51527f6f4f35a73cd521472c7a50 to know how to use the changes on this branch
Introduced DelayUtil
…Safe/web3.unity into oleksandr/fix-dependencies
sneakzttv
approved these changes
Apr 29, 2024
sneakzttv
added
ready-to-merge
sneakzttv
added a commit
that referenced
this pull request
Apr 29, 2024
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]>
sneakzttv
added a commit
that referenced
this pull request
Apr 30, 2024
* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]>
sneakzttv
added a commit
that referenced
this pull request
Apr 30, 2024
* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]>
sneakzttv
added a commit
that referenced
this pull request
Apr 30, 2024
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (#930) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Ramp fix (#931) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Sneakz/typo fix (#933) Update DisableGameObjectIfServiceNotActive.cs * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: sneakzttv <[email protected]>
sneakzttv
added a commit
that referenced
this pull request
Apr 30, 2024
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (#930) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Ramp fix (#931) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Sneakz/typo fix (#933) Update DisableGameObjectIfServiceNotActive.cs * Removing Sygma from ILoginProvider * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Update ILoginProvider.cs --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: Nikola Garabandic <[email protected]> Co-authored-by: sneakzttv <[email protected]>
rob1997
added a commit
that referenced
this pull request
Jan 16, 2025
* Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]>
rob1997
added a commit
that referenced
this pull request
Jan 16, 2025
* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]>
rob1997
added a commit
that referenced
this pull request
Jan 16, 2025
* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]> Co-authored-by: kantagara <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]> Co-authored-by: oleksandr <[email protected]> Co-authored-by: oleksandrchainsafe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juans-chainsafe Please check the SDK integration flow into a new project. Use Git URL to import the package as described in the Getting Started page. There should be no compile errors in the console.
Error example:
Library\PackageCache\io.chainsafe.web3-unity@6519654050\Runtime\Common\Scripts\ILoginProvider.cs(7,24): error CS0234: The type or namespace name 'Marketplace' does not exist in the namespace 'ChainSafe.Gaming' (are you missing an assembly reference?)Important note: Run
publish-to-unity-package.shscript first.