Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded Wallet PR - 1 #1272

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Embedded Wallet PR - 1 #1272

merged 11 commits into from
Jan 22, 2025

Conversation

rob1997
Copy link
Collaborator

@rob1997 rob1997 commented Jan 14, 2025

Embedded Wallet implemented as a Project
EmbeddedWalletTransactionExecutor implemented, used in Web3Auth
Embedded Wallet UI implemented (just UI for now)
Old Web3Auth Wallet GUI refactored for this new implementation

image
image

@rob1997 rob1997 self-assigned this Jan 14, 2025
@rob1997 rob1997 marked this pull request as ready for review January 16, 2025 07:54
@rob1997 rob1997 requested a review from kantagara January 16, 2025 10:04
@rob1997 rob1997 added documented Apply on Pull Request after documentation to allow merge ready-to-merge Ready to Merge PR - this'll trigger required checks labels Jan 16, 2025
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following build error after run setup.sh:

/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/Reown/NativeWebSocketConnectionBuilder.cs(13,68): error CS0535: 'NativeWebSocketConnectionBuilder' does not implement interface member 'IConnectionBuilder.CreateConnection(string, string)'

@rob1997
Copy link
Collaborator Author

rob1997 commented Jan 21, 2025

I see the following build error after run setup.sh:

/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/Reown/NativeWebSocketConnectionBuilder.cs(13,68): error CS0535: 'NativeWebSocketConnectionBuilder' does not implement interface member 'IConnectionBuilder.CreateConnection(string, string)'

Running setup.sh works fine on my end, perhaps you need to reset your repo, but WebGL wasn't building and I've fixed that

@rob1997 rob1997 force-pushed the rob/embedded-wallet-ui-1228 branch from 250d282 to a202d79 Compare January 21, 2025 15:53
@rob1997 rob1997 force-pushed the rob/embedded-wallet-ui-1228 branch from a202d79 to a04bf39 Compare January 21, 2025 16:04
@rob1997 rob1997 force-pushed the dev branch 2 times, most recently from 6501431 to ae69f12 Compare January 21, 2025 16:05
@rob1997 rob1997 force-pushed the rob/embedded-wallet-ui-1228 branch 2 times, most recently from 18e7c5b to 4d92998 Compare January 21, 2025 16:12
@rob1997 rob1997 force-pushed the rob/embedded-wallet-ui-1228 branch from 4d92998 to 0402b8e Compare January 21, 2025 16:15
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good in the editor, but I got this error when trying to build on WebGL:

IndexOutOfRangeException: Index was outside the bounds of the array.
UnityEditor.WebGL.WebGlBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args) (at <bc61694a430045aa840dd5427917ecbb>:0)
UnityEditor.Modules.DefaultBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args, UnityEditor.BuildProperties& outProperties) (at /Users/bokken/build/output/unity/unity/Editor/Mono/Modules/DefaultBuildPostprocessor.cs:30)
UnityEditor.PostprocessBuildPlayer.Postprocess (UnityEditor.BuildTargetGroup targetGroup, UnityEditor.BuildTarget target, System.Int32 subtarget, System.String installPath, System.String companyName, System.String productName, System.Int32 width, System.Int32 height, UnityEditor.BuildOptions options, UnityEditor.RuntimeClassRegistry usedClassRegistry, UnityEditor.Build.Reporting.BuildReport report) (at /Users/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline/PostprocessBuildPlayer.cs:370)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&) (at /Users/bokken/build/output/unity/unity/Modules/IMGUI/GUIUtility.cs:203)

Build completed with a result of 'Failed' in 21 seconds (20899 ms)
IndexOutOfRangeException: Index was outside the bounds of the array.
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&) (at /Users/bokken/build/output/unity/unity/Modules/IMGUI/GUIUtility.cs:203)

@kantagara
Copy link
Contributor

@juans-chainsafe just open player settings and select proper webgl template

@juans-chainsafe
Copy link
Contributor

@juans-chainsafe just open player settings and select proper webgl template

yes, that one is selected by default, but now Im not getting the error. Not sure what changed, restarting Unity? or bring dev changes to this branch. Or when I first open Player settings, our template is selected

@kantagara
Copy link
Contributor

restarting

We have that under FAQ. Rob also couldn't figure the issue, but the root cause is that it couldn't find the template even tho the template IS there, so it's on Unity

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web3Auth working as expected in editor and WebGL. Samples are also working.

@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Jan 22, 2025
@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Jan 22, 2025
@rob1997 rob1997 requested a review from kantagara January 22, 2025 18:37
@rob1997 rob1997 merged commit a31904d into dev Jan 22, 2025
7 checks passed
@rob1997 rob1997 deleted the rob/embedded-wallet-ui-1228 branch January 22, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documented Apply on Pull Request after documentation to allow merge ready-to-merge Ready to Merge PR - this'll trigger required checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants