Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing erc721 and erc1155 samples reported by Juan. #1247

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fixing erc721 and erc1155 samples reported by Juan. #1247

merged 2 commits into from
Nov 27, 2024

Conversation

kantagara
Copy link
Contributor

@kantagara kantagara commented Nov 27, 2024 •
edited
Loading

Closes #1233 #1234

@kantagara kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks documented Apply on Pull Request after documentation to allow merge labels Nov 27, 2024
@kantagara kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks documented Apply on Pull Request after documentation to allow merge and removed ready-to-merge Ready to Merge PR - this'll trigger required checks documented Apply on Pull Request after documentation to allow merge labels Nov 27, 2024
@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 27, 2024
juans-chainsafe
juans-chainsafe approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both samples are now working!

Screenshot 2024-11-27 at 10 32 18 AM

@kantagara kantagara merged commit 1152e74 into dev Nov 27, 2024
14 checks passed
@kantagara kantagara deleted the nikola/samples-fix-1233-1234 branch November 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob1997 rob1997 rob1997 approved these changes

@juans-chainsafe juans-chainsafe juans-chainsafe approved these changes

@creeppak creeppak Awaiting requested review from creeppak

@sneakzttv sneakzttv Awaiting requested review from sneakzttv

Assignees

@kantagara kantagara

Labels
documented Apply on Pull Request after documentation to allow merge ready-to-merge Ready to Merge PR - this'll trigger required checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kantagara @rob1997 @juans-chainsafe