Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow keymanager to configure a validator pubkey utf8 graffiti #6083

Merged
merged 3 commits into from
Nov 3, 2023
Merged

feat: allow keymanager to configure a validator pubkey utf8 graffiti #6083

merged 3 commits into from
Nov 3, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Nov 3, 2023

allow graffiti configuration per validator to bring in par with proposerSetting file functionality

@g11tech g11tech requested a review from a team as a code owner November 3, 2023 13:34
nflaig
nflaig reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably also update test cases in packages/cli/test/e2e/propserConfigfromKeymanager.test.ts

packages/cli/src/cmds/validator/keymanager/impl.ts Outdated Show resolved Hide resolved
packages/validator/src/services/validatorStore.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: 2d9527c Previous: a311a8b Ratio
forkChoice updateHead vc 600000 bc 64 eq 300000 16.512 ms/op 55.077 ms/op 0.30
Full benchmark results
Benchmark suite Current: 2d9527c Previous: a311a8b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 748.80 us/op 526.27 us/op 1.42
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 91.199 us/op 87.475 us/op 1.04
BLS verify - blst-native 1.3439 ms/op 1.3281 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.9094 ms/op 2.8473 ms/op 1.02
BLS verifyMultipleSignatures 8 - blst-native 6.1936 ms/op 6.0661 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 22.719 ms/op 22.138 ms/op 1.03
BLS verifyMultipleSignatures 64 - blst-native 44.640 ms/op 43.618 ms/op 1.02
BLS verifyMultipleSignatures 128 - blst-native 89.485 ms/op 88.147 ms/op 1.02
BLS deserializing 10000 signatures 931.63 ms/op 935.97 ms/op 1.00
BLS deserializing 100000 signatures 9.4632 s/op 9.4592 s/op 1.00
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3855 ms/op 1.3861 ms/op 1.00
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.7465 ms/op 1.5652 ms/op 1.12
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.4267 ms/op 2.4265 ms/op 1.00
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.5764 ms/op 3.5590 ms/op 1.00
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.2397 ms/op 7.2337 ms/op 0.86
BLS aggregatePubkeys 32 - blst-native 27.453 us/op 28.454 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 109.23 us/op 105.23 us/op 1.04
getAttestationsForBlock 50.487 ms/op 43.556 ms/op 1.16
isKnown best case - 1 super set check 576.00 ns/op 519.00 ns/op 1.11
isKnown normal case - 2 super set checks 683.00 ns/op 438.00 ns/op 1.56
isKnown worse case - 16 super set checks 656.00 ns/op 440.00 ns/op 1.49
CheckpointStateCache - add get delete 6.6110 us/op 6.5920 us/op 1.00
validate api signedAggregateAndProof - struct 2.8836 ms/op 2.8646 ms/op 1.01
validate gossip signedAggregateAndProof - struct 2.9750 ms/op 2.8993 ms/op 1.03
validate gossip attestation - vc 640000 1.4170 ms/op 1.4152 ms/op 1.00
batch validate gossip attestation - vc 640000 - chunk 32 174.73 us/op 167.61 us/op 1.04
batch validate gossip attestation - vc 640000 - chunk 64 154.80 us/op 145.37 us/op 1.06
batch validate gossip attestation - vc 640000 - chunk 128 147.40 us/op 135.34 us/op 1.09
batch validate gossip attestation - vc 640000 - chunk 256 141.56 us/op 143.28 us/op 0.99
pickEth1Vote - no votes 1.3205 ms/op 1.3652 ms/op 0.97
pickEth1Vote - max votes 9.8334 ms/op 10.548 ms/op 0.93
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.598 ms/op 19.183 ms/op 0.92
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.270 ms/op 25.918 ms/op 0.94
pickEth1Vote - Eth1Data fastSerialize value x2048 731.98 us/op 714.00 us/op 1.03
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.5178 ms/op 6.0616 ms/op 0.91
bytes32 toHexString 667.00 ns/op 565.00 ns/op 1.18
bytes32 Buffer.toString(hex) 324.00 ns/op 312.00 ns/op 1.04
bytes32 Buffer.toString(hex) from Uint8Array 563.00 ns/op 481.00 ns/op 1.17
bytes32 Buffer.toString(hex) + 0x 332.00 ns/op 304.00 ns/op 1.09
Object access 1 prop 0.18400 ns/op 0.16900 ns/op 1.09
Map access 1 prop 0.14500 ns/op 0.15100 ns/op 0.96
Object get x1000 7.9550 ns/op 7.7850 ns/op 1.02
Map get x1000 0.62800 ns/op 0.62900 ns/op 1.00
Object set x1000 59.101 ns/op 56.591 ns/op 1.04
Map set x1000 41.086 ns/op 42.450 ns/op 0.97
Return object 10000 times 0.24810 ns/op 0.26750 ns/op 0.93
Throw Error 10000 times 3.9368 us/op 4.0297 us/op 0.98
fastMsgIdFn sha256 / 200 bytes 3.3780 us/op 3.4370 us/op 0.98
fastMsgIdFn h32 xxhash / 200 bytes 289.00 ns/op 327.00 ns/op 0.88
fastMsgIdFn h64 xxhash / 200 bytes 366.00 ns/op 361.00 ns/op 1.01
fastMsgIdFn sha256 / 1000 bytes 11.637 us/op 11.817 us/op 0.98
fastMsgIdFn h32 xxhash / 1000 bytes 462.00 ns/op 454.00 ns/op 1.02
fastMsgIdFn h64 xxhash / 1000 bytes 444.00 ns/op 426.00 ns/op 1.04
fastMsgIdFn sha256 / 10000 bytes 104.69 us/op 106.00 us/op 0.99
fastMsgIdFn h32 xxhash / 10000 bytes 1.9770 us/op 2.0230 us/op 0.98
fastMsgIdFn h64 xxhash / 10000 bytes 1.3790 us/op 1.3980 us/op 0.99
send data - 1000 256B messages 20.089 ms/op 20.324 ms/op 0.99
send data - 1000 512B messages 28.686 ms/op 28.895 ms/op 0.99
send data - 1000 1024B messages 44.281 ms/op 43.369 ms/op 1.02
send data - 1000 1200B messages 25.035 ms/op 36.828 ms/op 0.68
send data - 1000 2048B messages 41.945 ms/op 43.996 ms/op 0.95
send data - 1000 4096B messages 41.771 ms/op 34.305 ms/op 1.22
send data - 1000 16384B messages 112.72 ms/op 113.80 ms/op 0.99
send data - 1000 65536B messages 361.23 ms/op 459.41 ms/op 0.79
enrSubnets - fastDeserialize 64 bits 1.3640 us/op 1.4050 us/op 0.97
enrSubnets - ssz BitVector 64 bits 431.00 ns/op 529.00 ns/op 0.81
enrSubnets - fastDeserialize 4 bits 180.00 ns/op 233.00 ns/op 0.77
enrSubnets - ssz BitVector 4 bits 423.00 ns/op 531.00 ns/op 0.80
prioritizePeers score -10:0 att 32-0.1 sync 2-0 100.83 us/op 116.88 us/op 0.86
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 135.12 us/op 142.63 us/op 0.95
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 156.81 us/op 189.27 us/op 0.83
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 287.00 us/op 344.57 us/op 0.83
prioritizePeers score 0:0 att 64-1 sync 4-1 348.36 us/op 390.30 us/op 0.89
array of 16000 items push then shift 1.6339 us/op 1.6769 us/op 0.97
LinkedList of 16000 items push then shift 8.8870 ns/op 9.7530 ns/op 0.91
array of 16000 items push then pop 93.521 ns/op 105.82 ns/op 0.88
LinkedList of 16000 items push then pop 8.6380 ns/op 9.3560 ns/op 0.92
array of 24000 items push then shift 2.4200 us/op 2.6603 us/op 0.91
LinkedList of 24000 items push then shift 8.9950 ns/op 9.8860 ns/op 0.91
array of 24000 items push then pop 125.25 ns/op 162.18 ns/op 0.77
LinkedList of 24000 items push then pop 8.6320 ns/op 9.2190 ns/op 0.94
intersect bitArray bitLen 8 6.8840 ns/op 7.1610 ns/op 0.96
intersect array and set length 8 57.862 ns/op 69.481 ns/op 0.83
intersect bitArray bitLen 128 32.269 ns/op 34.717 ns/op 0.93
intersect array and set length 128 787.97 ns/op 993.88 ns/op 0.79
bitArray.getTrueBitIndexes() bitLen 128 1.5640 us/op 1.7800 us/op 0.88
bitArray.getTrueBitIndexes() bitLen 248 2.8410 us/op 3.1410 us/op 0.90
bitArray.getTrueBitIndexes() bitLen 512 5.0870 us/op 5.7900 us/op 0.88
Buffer.concat 32 items 1.0300 us/op 1.0560 us/op 0.98
Uint8Array.set 32 items 1.6530 us/op 1.9420 us/op 0.85
Set add up to 64 items then delete first 4.4629 us/op 5.1282 us/op 0.87
OrderedSet add up to 64 items then delete first 5.5084 us/op 6.7759 us/op 0.81
Set add up to 64 items then delete last 4.6621 us/op 5.5969 us/op 0.83
OrderedSet add up to 64 items then delete last 5.6862 us/op 7.2667 us/op 0.78
Set add up to 64 items then delete middle 4.8593 us/op 5.5359 us/op 0.88
OrderedSet add up to 64 items then delete middle 7.0838 us/op 8.7835 us/op 0.81
Set add up to 128 items then delete first 9.7676 us/op 10.650 us/op 0.92
OrderedSet add up to 128 items then delete first 12.575 us/op 14.239 us/op 0.88
Set add up to 128 items then delete last 9.1474 us/op 10.564 us/op 0.87
OrderedSet add up to 128 items then delete last 11.725 us/op 14.561 us/op 0.81
Set add up to 128 items then delete middle 9.7730 us/op 10.576 us/op 0.92
OrderedSet add up to 128 items then delete middle 17.243 us/op 19.368 us/op 0.89
Set add up to 256 items then delete first 18.903 us/op 20.566 us/op 0.92
OrderedSet add up to 256 items then delete first 25.253 us/op 31.362 us/op 0.81
Set add up to 256 items then delete last 18.379 us/op 22.117 us/op 0.83
OrderedSet add up to 256 items then delete last 23.436 us/op 29.087 us/op 0.81
Set add up to 256 items then delete middle 18.135 us/op 21.737 us/op 0.83
OrderedSet add up to 256 items then delete middle 45.091 us/op 52.410 us/op 0.86
transfer serialized Status (84 B) 1.7960 us/op 1.9200 us/op 0.94
copy serialized Status (84 B) 1.4740 us/op 1.8100 us/op 0.81
transfer serialized SignedVoluntaryExit (112 B) 1.9100 us/op 2.3050 us/op 0.83
copy serialized SignedVoluntaryExit (112 B) 1.5420 us/op 2.0150 us/op 0.77
transfer serialized ProposerSlashing (416 B) 2.0380 us/op 3.1890 us/op 0.64
copy serialized ProposerSlashing (416 B) 1.8090 us/op 3.0850 us/op 0.59
transfer serialized Attestation (485 B) 2.0450 us/op 3.5710 us/op 0.57
copy serialized Attestation (485 B) 1.8460 us/op 3.3790 us/op 0.55
transfer serialized AttesterSlashing (33232 B) 2.2600 us/op 2.9830 us/op 0.76
copy serialized AttesterSlashing (33232 B) 5.2400 us/op 8.0970 us/op 0.65
transfer serialized Small SignedBeaconBlock (128000 B) 2.6120 us/op 3.3450 us/op 0.78
copy serialized Small SignedBeaconBlock (128000 B) 13.829 us/op 16.938 us/op 0.82
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1000 us/op 4.1960 us/op 0.74
copy serialized Avg SignedBeaconBlock (200000 B) 21.367 us/op 31.452 us/op 0.68
transfer serialized BlobsSidecar (524380 B) 3.0720 us/op 4.1010 us/op 0.75
copy serialized BlobsSidecar (524380 B) 80.556 us/op 220.66 us/op 0.37
transfer serialized Big SignedBeaconBlock (1000000 B) 3.6450 us/op 6.2650 us/op 0.58
copy serialized Big SignedBeaconBlock (1000000 B) 159.46 us/op 202.12 us/op 0.79
pass gossip attestations to forkchoice per slot 3.8904 ms/op 4.4891 ms/op 0.87
forkChoice updateHead vc 100000 bc 64 eq 0 660.60 us/op 761.06 us/op 0.87
forkChoice updateHead vc 600000 bc 64 eq 0 4.0385 ms/op 4.9194 ms/op 0.82
forkChoice updateHead vc 1000000 bc 64 eq 0 7.3880 ms/op 7.7290 ms/op 0.96
forkChoice updateHead vc 600000 bc 320 eq 0 4.2502 ms/op 4.6120 ms/op 0.92
forkChoice updateHead vc 600000 bc 1200 eq 0 4.3275 ms/op 4.7604 ms/op 0.91
forkChoice updateHead vc 600000 bc 7200 eq 0 5.2600 ms/op 6.8695 ms/op 0.77
forkChoice updateHead vc 600000 bc 64 eq 1000 11.786 ms/op 13.242 ms/op 0.89
forkChoice updateHead vc 600000 bc 64 eq 10000 12.579 ms/op 15.801 ms/op 0.80
forkChoice updateHead vc 600000 bc 64 eq 300000 16.512 ms/op 55.077 ms/op 0.30
computeDeltas 500000 validators 300 proto nodes 6.4334 ms/op 7.1914 ms/op 0.89
computeDeltas 500000 validators 1200 proto nodes 6.6548 ms/op 6.9650 ms/op 0.96
computeDeltas 500000 validators 7200 proto nodes 8.0616 ms/op 6.9439 ms/op 1.16
computeDeltas 750000 validators 300 proto nodes 12.387 ms/op 11.239 ms/op 1.10
computeDeltas 750000 validators 1200 proto nodes 12.877 ms/op 9.9880 ms/op 1.29
computeDeltas 750000 validators 7200 proto nodes 14.116 ms/op 10.314 ms/op 1.37
computeDeltas 1400000 validators 300 proto nodes 38.197 ms/op 19.970 ms/op 1.91
computeDeltas 1400000 validators 1200 proto nodes 38.373 ms/op 18.933 ms/op 2.03
computeDeltas 1400000 validators 7200 proto nodes 37.012 ms/op 19.484 ms/op 1.90
computeDeltas 2100000 validators 300 proto nodes 27.174 ms/op 29.006 ms/op 0.94
computeDeltas 2100000 validators 1200 proto nodes 55.950 ms/op 29.244 ms/op 1.91
computeDeltas 2100000 validators 7200 proto nodes 55.157 ms/op 29.971 ms/op 1.84
computeProposerBoostScoreFromBalances 500000 validators 3.3205 ms/op 3.5125 ms/op 0.95
computeProposerBoostScoreFromBalances 750000 validators 3.2736 ms/op 3.5055 ms/op 0.93
computeProposerBoostScoreFromBalances 1400000 validators 3.3121 ms/op 3.6256 ms/op 0.91
computeProposerBoostScoreFromBalances 2100000 validators 3.3137 ms/op 3.5986 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei normalcase 2.3643 ms/op 3.9631 ms/op 0.60
altair processAttestation - 250000 vs - 7PWei worstcase 3.1195 ms/op 4.8119 ms/op 0.65
altair processAttestation - setStatus - 1/6 committees join 139.28 us/op 243.74 us/op 0.57
altair processAttestation - setStatus - 1/3 committees join 275.13 us/op 424.00 us/op 0.65
altair processAttestation - setStatus - 1/2 committees join 372.88 us/op 539.55 us/op 0.69
altair processAttestation - setStatus - 2/3 committees join 471.34 us/op 698.14 us/op 0.68
altair processAttestation - setStatus - 4/5 committees join 655.72 us/op 933.37 us/op 0.70
altair processAttestation - setStatus - 100% committees join 794.71 us/op 1.0519 ms/op 0.76
altair processBlock - 250000 vs - 7PWei normalcase 11.302 ms/op 12.101 ms/op 0.93
altair processBlock - 250000 vs - 7PWei normalcase hashState 35.334 ms/op 51.639 ms/op 0.68
altair processBlock - 250000 vs - 7PWei worstcase 41.191 ms/op 48.708 ms/op 0.85
altair processBlock - 250000 vs - 7PWei worstcase hashState 90.318 ms/op 101.52 ms/op 0.89
phase0 processBlock - 250000 vs - 7PWei normalcase 2.9580 ms/op 4.0756 ms/op 0.73
phase0 processBlock - 250000 vs - 7PWei worstcase 33.358 ms/op 38.792 ms/op 0.86
altair processEth1Data - 250000 vs - 7PWei normalcase 667.21 us/op 1.0689 ms/op 0.62
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 16.944 us/op 21.107 us/op 0.80
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 68.764 us/op 126.35 us/op 0.54
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 22.540 us/op 46.639 us/op 0.48
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 13.600 us/op 23.852 us/op 0.57
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 225.91 us/op 252.88 us/op 0.89
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.5691 ms/op 2.0488 ms/op 0.77
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.0986 ms/op 2.3405 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.8149 ms/op 2.4059 ms/op 0.75
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.1959 ms/op 6.3871 ms/op 0.66
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.8508 ms/op 3.6052 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.4261 ms/op 14.658 ms/op 0.37
Tree 40 250000 create 467.13 ms/op 1.0760 s/op 0.43
Tree 40 250000 get(125000) 212.66 ns/op 263.85 ns/op 0.81
Tree 40 250000 set(125000) 1.3505 us/op 3.3813 us/op 0.40
Tree 40 250000 toArray() 23.305 ms/op 35.889 ms/op 0.65
Tree 40 250000 iterate all - toArray() + loop 23.614 ms/op 37.497 ms/op 0.63
Tree 40 250000 iterate all - get(i) 77.047 ms/op 102.28 ms/op 0.75
MutableVector 250000 create 13.944 ms/op 25.486 ms/op 0.55
MutableVector 250000 get(125000) 6.7560 ns/op 12.244 ns/op 0.55
MutableVector 250000 set(125000) 346.17 ns/op 854.56 ns/op 0.41
MutableVector 250000 toArray() 5.0963 ms/op 6.7441 ms/op 0.76
MutableVector 250000 iterate all - toArray() + loop 4.8393 ms/op 6.8621 ms/op 0.71
MutableVector 250000 iterate all - get(i) 1.5855 ms/op 2.9729 ms/op 0.53
Array 250000 create 4.6384 ms/op 6.9340 ms/op 0.67
Array 250000 clone - spread 1.7892 ms/op 7.2508 ms/op 0.25
Array 250000 get(125000) 0.99000 ns/op 2.9660 ns/op 0.33
Array 250000 set(125000) 1.0050 ns/op 2.8780 ns/op 0.35
Array 250000 iterate all - loop 104.10 us/op 141.19 us/op 0.74
effectiveBalanceIncrements clone Uint8Array 300000 68.459 us/op 98.836 us/op 0.69
effectiveBalanceIncrements clone MutableVector 300000 466.00 ns/op 2.5130 us/op 0.19
effectiveBalanceIncrements rw all Uint8Array 300000 194.01 us/op 238.91 us/op 0.81
effectiveBalanceIncrements rw all MutableVector 300000 140.84 ms/op 266.23 ms/op 0.53
phase0 afterProcessEpoch - 250000 vs - 7PWei 121.82 ms/op 186.06 ms/op 0.65
phase0 beforeProcessEpoch - 250000 vs - 7PWei 58.931 ms/op 70.901 ms/op 0.83
altair processEpoch - mainnet_e81889 567.38 ms/op 718.45 ms/op 0.79
mainnet_e81889 - altair beforeProcessEpoch 113.99 ms/op 122.22 ms/op 0.93
mainnet_e81889 - altair processJustificationAndFinalization 30.200 us/op 39.245 us/op 0.77
mainnet_e81889 - altair processInactivityUpdates 10.041 ms/op 9.8384 ms/op 1.02
mainnet_e81889 - altair processRewardsAndPenalties 72.533 ms/op 82.439 ms/op 0.88
mainnet_e81889 - altair processRegistryUpdates 5.6360 us/op 7.8780 us/op 0.72
mainnet_e81889 - altair processSlashings 1.1700 us/op 1.4670 us/op 0.80
mainnet_e81889 - altair processEth1DataReset 1.3390 us/op 1.9630 us/op 0.68
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.2084 ms/op 2.3112 ms/op 0.96
mainnet_e81889 - altair processSlashingsReset 7.2140 us/op 9.4930 us/op 0.76
mainnet_e81889 - altair processRandaoMixesReset 10.592 us/op 13.710 us/op 0.77
mainnet_e81889 - altair processHistoricalRootsUpdate 2.7100 us/op 2.3050 us/op 1.18
mainnet_e81889 - altair processParticipationFlagUpdates 5.0560 us/op 6.0590 us/op 0.83
mainnet_e81889 - altair processSyncCommitteeUpdates 1.6300 us/op 2.3080 us/op 0.71
mainnet_e81889 - altair afterProcessEpoch 143.37 ms/op 138.76 ms/op 1.03
capella processEpoch - mainnet_e217614 3.6643 s/op 2.8448 s/op 1.29
mainnet_e217614 - capella beforeProcessEpoch 805.32 ms/op 552.62 ms/op 1.46
mainnet_e217614 - capella processJustificationAndFinalization 22.730 us/op 20.360 us/op 1.12
mainnet_e217614 - capella processInactivityUpdates 29.362 ms/op 22.486 ms/op 1.31
mainnet_e217614 - capella processRewardsAndPenalties 765.64 ms/op 615.74 ms/op 1.24
mainnet_e217614 - capella processRegistryUpdates 23.879 us/op 33.656 us/op 0.71
mainnet_e217614 - capella processSlashings 1.1110 us/op 775.00 ns/op 1.43
mainnet_e217614 - capella processEth1DataReset 1.0320 us/op 618.00 ns/op 1.67
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.3576 ms/op 4.4755 ms/op 0.97
mainnet_e217614 - capella processSlashingsReset 3.6620 us/op 3.9690 us/op 0.92
mainnet_e217614 - capella processRandaoMixesReset 6.2770 us/op 6.9960 us/op 0.90
mainnet_e217614 - capella processHistoricalRootsUpdate 997.00 ns/op 707.00 ns/op 1.41
mainnet_e217614 - capella processParticipationFlagUpdates 3.3480 us/op 2.6430 us/op 1.27
mainnet_e217614 - capella afterProcessEpoch 340.17 ms/op 324.19 ms/op 1.05
phase0 processEpoch - mainnet_e58758 496.50 ms/op 530.15 ms/op 0.94
mainnet_e58758 - phase0 beforeProcessEpoch 137.95 ms/op 170.20 ms/op 0.81
mainnet_e58758 - phase0 processJustificationAndFinalization 18.729 us/op 26.850 us/op 0.70
mainnet_e58758 - phase0 processRewardsAndPenalties 67.568 ms/op 74.553 ms/op 0.91
mainnet_e58758 - phase0 processRegistryUpdates 15.344 us/op 20.149 us/op 0.76
mainnet_e58758 - phase0 processSlashings 653.00 ns/op 876.00 ns/op 0.75
mainnet_e58758 - phase0 processEth1DataReset 640.00 ns/op 705.00 ns/op 0.91
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0652 ms/op 1.2800 ms/op 0.83
mainnet_e58758 - phase0 processSlashingsReset 2.9940 us/op 5.1420 us/op 0.58
mainnet_e58758 - phase0 processRandaoMixesReset 4.8160 us/op 9.8110 us/op 0.49
mainnet_e58758 - phase0 processHistoricalRootsUpdate 460.00 ns/op 982.00 ns/op 0.47
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.8260 us/op 8.0630 us/op 0.47
mainnet_e58758 - phase0 afterProcessEpoch 103.81 ms/op 107.83 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2785 ms/op 1.3402 ms/op 0.95
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4814 ms/op 1.6578 ms/op 0.89
altair processInactivityUpdates - 250000 normalcase 22.609 ms/op 24.819 ms/op 0.91
altair processInactivityUpdates - 250000 worstcase 23.007 ms/op 23.806 ms/op 0.97
phase0 processRegistryUpdates - 250000 normalcase 10.523 us/op 13.084 us/op 0.80
phase0 processRegistryUpdates - 250000 badcase_full_deposits 376.50 us/op 446.74 us/op 0.84
phase0 processRegistryUpdates - 250000 worstcase 0.5 151.39 ms/op 177.53 ms/op 0.85
altair processRewardsAndPenalties - 250000 normalcase 75.437 ms/op 73.259 ms/op 1.03
altair processRewardsAndPenalties - 250000 worstcase 80.947 ms/op 76.296 ms/op 1.06
phase0 getAttestationDeltas - 250000 normalcase 11.661 ms/op 12.602 ms/op 0.93
phase0 getAttestationDeltas - 250000 worstcase 10.772 ms/op 11.970 ms/op 0.90
phase0 processSlashings - 250000 worstcase 2.4619 ms/op 2.4855 ms/op 0.99
altair processSyncCommitteeUpdates - 250000 176.66 ms/op 185.96 ms/op 0.95
BeaconState.hashTreeRoot - No change 263.00 ns/op 268.00 ns/op 0.98
BeaconState.hashTreeRoot - 1 full validator 132.71 us/op 183.49 us/op 0.72
BeaconState.hashTreeRoot - 32 full validator 1.4369 ms/op 2.1315 ms/op 0.67
BeaconState.hashTreeRoot - 512 full validator 15.974 ms/op 17.267 ms/op 0.93
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 175.63 us/op 176.32 us/op 1.00
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.2170 ms/op 2.9212 ms/op 0.76
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 30.838 ms/op 33.428 ms/op 0.92
BeaconState.hashTreeRoot - 1 balances 174.09 us/op 172.61 us/op 1.01
BeaconState.hashTreeRoot - 32 balances 1.5313 ms/op 1.4005 ms/op 1.09
BeaconState.hashTreeRoot - 512 balances 13.675 ms/op 14.598 ms/op 0.94
BeaconState.hashTreeRoot - 250000 balances 216.73 ms/op 241.53 ms/op 0.90
aggregationBits - 2048 els - zipIndexesInBitList 21.807 us/op 33.155 us/op 0.66
byteArrayEquals 32 52.770 ns/op 53.951 ns/op 0.98
Buffer.compare 32 57.389 ns/op 58.486 ns/op 0.98
byteArrayEquals 1024 1.5242 us/op 1.5843 us/op 0.96
Buffer.compare 1024 74.058 ns/op 75.613 ns/op 0.98
byteArrayEquals 16384 24.187 us/op 25.334 us/op 0.95
Buffer.compare 16384 257.16 ns/op 272.10 ns/op 0.95
byteArrayEquals 123687377 186.62 ms/op 195.63 ms/op 0.95
Buffer.compare 123687377 11.285 ms/op 10.589 ms/op 1.07
byteArrayEquals 32 - diff last byte 57.764 ns/op 57.527 ns/op 1.00
Buffer.compare 32 - diff last byte 60.344 ns/op 64.691 ns/op 0.93
byteArrayEquals 1024 - diff last byte 1.5293 us/op 1.5565 us/op 0.98
Buffer.compare 1024 - diff last byte 76.461 ns/op 77.721 ns/op 0.98
byteArrayEquals 16384 - diff last byte 24.282 us/op 24.544 us/op 0.99
Buffer.compare 16384 - diff last byte 264.19 ns/op 288.66 ns/op 0.92
byteArrayEquals 123687377 - diff last byte 183.74 ms/op 196.51 ms/op 0.94
Buffer.compare 123687377 - diff last byte 10.201 ms/op 11.109 ms/op 0.92
byteArrayEquals 32 - random bytes 7.2320 ns/op 7.7120 ns/op 0.94
Buffer.compare 32 - random bytes 63.590 ns/op 67.960 ns/op 0.94
byteArrayEquals 1024 - random bytes 6.9580 ns/op 7.3520 ns/op 0.95
Buffer.compare 1024 - random bytes 62.560 ns/op 67.397 ns/op 0.93
byteArrayEquals 16384 - random bytes 6.7370 ns/op 7.5290 ns/op 0.89
Buffer.compare 16384 - random bytes 62.453 ns/op 68.414 ns/op 0.91
byteArrayEquals 123687377 - random bytes 10.200 ns/op 13.050 ns/op 0.78
Buffer.compare 123687377 - random bytes 77.280 ns/op 80.000 ns/op 0.97
regular array get 100000 times 36.533 us/op 38.048 us/op 0.96
wrappedArray get 100000 times 35.567 us/op 37.253 us/op 0.95
arrayWithProxy get 100000 times 15.723 ms/op 16.208 ms/op 0.97
ssz.Root.equals 54.674 ns/op 61.368 ns/op 0.89
byteArrayEquals 51.858 ns/op 56.921 ns/op 0.91
Buffer.compare 12.181 ns/op 14.111 ns/op 0.86
shuffle list - 16384 els 7.3667 ms/op 8.0968 ms/op 0.91
shuffle list - 250000 els 107.68 ms/op 119.53 ms/op 0.90
processSlot - 1 slots 18.180 us/op 19.898 us/op 0.91
processSlot - 32 slots 3.4998 ms/op 3.4305 ms/op 1.02
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 65.152 ms/op 64.836 ms/op 1.00
getCommitteeAssignments - req 1 vs - 250000 vc 2.5968 ms/op 2.6865 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 3.8775 ms/op 4.1390 ms/op 0.94
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3042 ms/op 4.4916 ms/op 0.96
findModifiedValidators - 10000 modified validators 597.88 ms/op 597.84 ms/op 1.00
findModifiedValidators - 1000 modified validators 531.33 ms/op 556.64 ms/op 0.95
findModifiedValidators - 100 modified validators 507.05 ms/op 493.56 ms/op 1.03
findModifiedValidators - 10 modified validators 523.98 ms/op 469.44 ms/op 1.12
findModifiedValidators - 1 modified validators 422.01 ms/op 454.20 ms/op 0.93
findModifiedValidators - no difference 470.40 ms/op 461.99 ms/op 1.02
compare ViewDUs 5.1736 s/op 5.0583 s/op 1.02
compare each validator Uint8Array 2.2156 s/op 2.1518 s/op 1.03
compare ViewDU to Uint8Array 1.4993 s/op 1.4707 s/op 1.02
migrate state 1000000 validators, 24 modified, 0 new 923.79 ms/op 894.94 ms/op 1.03
migrate state 1000000 validators, 1700 modified, 1000 new 1.1633 s/op 1.1949 s/op 0.97
migrate state 1000000 validators, 3400 modified, 2000 new 1.4509 s/op 1.3407 s/op 1.08
migrate state 1500000 validators, 24 modified, 0 new 782.25 ms/op 768.28 ms/op 1.02
migrate state 1500000 validators, 1700 modified, 1000 new 1.0653 s/op 1.0844 s/op 0.98
migrate state 1500000 validators, 3400 modified, 2000 new 1.4335 s/op 1.3544 s/op 1.06
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.8200 ns/op 4.5200 ns/op 1.07
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1237 us/op 667.55 ns/op 1.68
computeProposers - vc 250000 11.594 ms/op 9.3947 ms/op 1.23
computeEpochShuffling - vc 250000 110.91 ms/op 109.54 ms/op 1.01
getNextSyncCommittee - vc 250000 178.33 ms/op 163.37 ms/op 1.09
computeSigningRoot for AttestationData 28.089 us/op 26.059 us/op 1.08
hash AttestationData serialized data then Buffer.toString(base64) 2.4434 us/op 2.4371 us/op 1.00
toHexString serialized data 1.5194 us/op 1.1437 us/op 1.33
Buffer.toString(base64) 246.48 ns/op 221.74 ns/op 1.11

by benchmarkbot/action

@g11tech g11tech enabled auto-merge (squash) November 3, 2023 15:24
nflaig
nflaig approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g11tech g11tech merged commit 52b9e15 into unstable Nov 3, 2023
@g11tech g11tech deleted the keymanager-graffiti branch November 3, 2023 15:44
@Pol-Lanski
Copy link

YO <3

@nflaig nflaig mentioned this pull request Nov 6, 2023
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g11tech @Pol-Lanski @wemeetagain @nflaig