Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix usage of dependant where should be dependent #6056

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

kevinheavey
Copy link
Contributor

Basically dependant is a noun and dependent is an adjective. There are some places where dependent should be used instead of dependant.

There are also a bunch of cases in the repo where it's not clear which word was intended, but the cases in this PR are clear.

https://www.easybib.com/guides/grammar-guides/vocabulary/confusing-words/dependant-vs-dependent/

@kevinheavey kevinheavey requested a review from a team as a code owner October 21, 2023 13:36
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2023

CLA assistant check
All committers have signed the CLA.

@nflaig
Copy link
Member

nflaig commented Oct 22, 2023

Thanks @kevinheavey, changes look good to me.

There are also code variables that could be updated in this PR

type DependantRootHex = RootHex;

According to beacon API spec, this should be called DependentRoot and dependent_root

@nflaig
Copy link
Member

nflaig commented Oct 22, 2023

Just noticed, if you search for "dependant root" you will find a bunch more that should be changed. I checked the consensus and beacon spec, there is no such thing as dependant root.

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @kevinheavey

@wemeetagain wemeetagain merged commit 5299e83 into ChainSafe:unstable Oct 24, 2023
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants