-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update peer-id #173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 76.58% 76.58%
=======================================
Files 2 2
Lines 1905 1905
Branches 144 144
=======================================
Hits 1459 1459
Misses 446 446
Continue to review full report at Codecov.
|
@achingbrain what breaks with Node < v16? |
Node only used to be able to give us keypairs in pem format, which we'd then use pem-jwk to transform to jwk - starting with node 15 it can give us the keys in jwk directly so we don't need the extra dep any more. https://github.com/libp2p/js-libp2p-crypto/blob/master/src/keys/rsa.js#L14-L15 |
Same with signing/verifying using RSA, we used to have to transform the key format before hand, now we can just pass it to node crypto directly. |
Is it feasible to have a fallback for Node v14? I haven't though in depth our node version support strategy but if the cost is low it's a good to have. |
It means adding the |
Agree with your policy, let's stick to v16 then |
e3f22a4
to
f801043
Compare
There's no need to use node buffers, everything is `Uint8Array` compatible now. Needs the `libp2p-interfaces-compliance-tests` upgrade from ChainSafe#173 before CI will pass.
Pulls in the new peer-id Needs a new release of `libp2p-floodsub` and `@chainsafe/libp2p-noise` though they are just dev deps so this could go out without them. BREAKING CHANGE: requires node 15+
f801043
to
fc6527d
Compare
Phew, CI passing. I think long term all the |
await connectGossipsubs(nodes) | ||
// await subscription propagation | ||
await delay(50) | ||
await waitForAllNodesToBePeered(nodes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's no need to use node buffers, everything is `Uint8Array` compatible now. Needs the `libp2p-interfaces-compliance-tests` upgrade from ChainSafe#173 before CI will pass.
There's no need to use node buffers, everything is `Uint8Array` compatible now. Needs the `libp2p-interfaces-compliance-tests` upgrade from #173 before CI will pass
Pulls in the new peer-id
Needs a new release of
@chainsafe/libp2p-noise
though it's just a dev dep so this could go out without it.BREAKING CHANGE: requires node 15+