chore: update libp2p-pubsub #110
Conversation
| subs.forEach((subOpt) => this._processRpcSubOpt(peer, subOpt)) | ||
| this.emit('pubsub:subscription-change', peer.id, peer.topics, subs) | ||
| subs.forEach((subOpt) => this._processRpcSubOpt(idB58Str, subOpt)) | ||
| this.emit('pubsub:subscription-change', peerStreams.id, subs) |
There was a problem hiding this comment.
Any strong reason to remove the topics the peer is subscribed from the event?
There was a problem hiding this comment.
We aren't indexing "peer => subscribed topics" anymore.
Previously the Peer maintained a list of topics - Peer#topics
Now we just have this.topics - topic => subscribed peers
we could:
- leave this as is, keeping this event modified
- loop thru all this.topics, collecting subscribed peers
- create another index, eg:
this.peerTopics- peer => subscribed topics
I've got a preference for 1 or 3
There was a problem hiding this comment.
Let's leave it for now. If we have something built on top of this information, we can reconsider what to do
|
CI seems broken. Any cache related issue? |
|
Yeah, just cleared the cache and rerunning now |
|
It seems the tests are failing w floodsub interop. Floodsub seems to be using the 0.6.x branch of libp2p-pubsub 🤔 |
|
I'll put in a PR to update floodsub, link to that branch here |
Update
libp2p-pubsubtov0.6.x(passes tests with libp2p/js-libp2p-pubsub#65 and libp2p/js-libp2p-pubsub#66 applied)InMessageobject to includereceivedFrompeer-id string(id: string, msg: InMessage)to just be(msg: InMessage)since InMessage now contains thereceivedFrompeer idvalidateto throw on invalid messages_processTopicValidatorResultin favor of overridingvalidatein order to apply validation penaltiespublish/_publishfor publishing a single messagepeer/PeerwithpeerStreams/PeerStreamsin many placespeerStreamsin many places)_onPeerConnected).