chore(dot/network): log the errors from stream.Close()
#2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
qdm12
as code owners
|
|
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2779 +/- ##
===============================================
- Coverage 63.03% 62.81% -0.22%
===============================================
Files 213 213
Lines 27021 27032 +11
===============================================
- Hits 17033 16981 -52
- Misses 8436 8495 +59
- Partials 1552 1556 +4 |
qdm12
suggested changes
Aug 24, 2022
axaysagathiya
requested review from
qdm12
and removed request for
timwu20,
edwardmack,
kishansagathiya,
EclesioMeloJunior,
noot and
jimjbrettj
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added the log of the errors returned from
stream.Close().Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Fixed #2376
Primary Reviewer
@timwu20