-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing(lib/trie): change lib/trie
slow and intensive benchmark-oriented tests to benchmarks
#2031
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2031 +/- ##
===============================================
+ Coverage 59.94% 60.10% +0.16%
===============================================
Files 185 193 +8
Lines 26343 26525 +182
===============================================
+ Hits 15790 15942 +152
- Misses 8677 8699 +22
- Partials 1876 1884 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a unit test for the parallel trie hashing? we should keep a unit test for it somewhere, but this change is fine
I'll add one in #2009 since I changed/improved the implementation for the parallel hashing. |
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…ented tests to benchmarks (ChainSafe#2031) - Change unit tests to a merged Go benchmark (you can run them with `go test -bench`) - Use deepcopy to copy the trie instead of re-generating one, which takes time - Use math/rand instead of crypto/rand to generate trie values faster
Changes
t.Skip()
themgo test -bench
)Tests
Issues
Primary Reviewer