Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/grandpa): Include equivocatory nodes while creating justification #1911
feat(lib/grandpa): Include equivocatory nodes while creating justification #1911
Changes from 7 commits
ef6546f
35fea30
1ceb49d
64b96fc
c2bf981
5039268
0100140
e2bafd8
b627509
d626dae
b0f3c27
7d21850
e6299b5
bbe8ba7
0ed4ce5
a5f4684
c9c278c
0274ef9
0b0c524
6e5dd0b
de8a4ed
f58afce
56f3d05
ad81602
c93a134
7abd69b
0301b49
ec61d8e
a7d9ecb
f1f4d04
5730645
69ee68d
5091650
349080b
32856fa
c10dc71
a0dd708
37b2ba3
add5820
e3546d8
9ac7015
3a4ee28
c675cab
9490f66
f3abef8
1bec0db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably throw an error if you pass an unsupported
Subround
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can leave this check in, as it will quickly check if there aren't enough precommits in the justification to ever be valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!