-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/babe): add check of types.ConfigData.SecondarySlots for disabling secondary verification #1910
Merged
edwardmack
merged 22 commits into
development
from
ed/use_types_configdata_secondarySlots
Nov 4, 2021
Merged
feat(lib/babe): add check of types.ConfigData.SecondarySlots for disabling secondary verification #1910
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c8b46b5
add check for types.ConfigData.SecondarySlots
edwardmack 250986d
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack 7d6f8cd
Update lib/babe/verify.go
edwardmack 3692fd0
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack 09e702c
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack d25c781
update ok = false if !b.secondarySlots
edwardmack c26553d
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack 4e2f925
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack 4ef4652
stub test for secondary verification
edwardmack ee0900d
add test to verify secondary digest
edwardmack 1e221c3
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack b6930bb
address PR comments
edwardmack 83a4591
add err check
edwardmack ac41b7a
update pointers to fix tests
edwardmack 2ae9e0f
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack b4f4fad
add tests for decoding
edwardmack da13828
my wip
timwu20 1c21820
fix VRF encoding
edwardmack 73f08b5
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack 1ee9ffc
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack 1d70d13
update linter tags
edwardmack fb16b0b
Merge branch 'development' into ed/use_types_configdata_secondarySlots
edwardmack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there's a secondary slot digest but
b.secondarySlots == false
then this should beok = false
, as the digest would be invalidThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.