maintenance: cleanup TODOs, add issues numbers to remaining TODOs #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
omar391 and
timwu20
as code owners
arijitAD
reviewed
Oct 11, 2021
| @@ -132,3 +132,19 @@ func NewTestGenesisWithTrieAndHeader(t *testing.T) (*Genesis, *trie.Trie, *types | |||
| require.NoError(t, err) | |||
| return gen, genTrie, genesisHeader | |||
| } | |||
|
|
|||
| // NewDevGenesisWithTrieAndHeader generates test dev genesis, genesis trie and genesis header | |||
There was a problem hiding this comment.
Can we merge code of NewTestGenesisWithTrieAndHeader and NewDevGenesisWithTrieAndHeader?
The code is similar except for the file name.
dot/digest/digest_test.go
Outdated
|
|
||
| return headers | ||
| } | ||
|
|
||
| func newTestHandler(t *testing.T, withBABE, withGrandpa bool) *Handler { //nolint |
There was a problem hiding this comment.
withBABE and withGrandpa are not used
dot/state/test_helpers.go
Outdated
| // AddBlocksToState adds blocks to a BlockState up to depth, with random branches | ||
| func AddBlocksToState(t *testing.T, blockState *BlockState, depth int) ([]*types.Header, []*types.Header) { | ||
| // AddBlocksToState adds `depth` number of blocks to the BlockState, optionally with random branches | ||
| func AddBlocksToState(t *testing.T, blockState *BlockState, depth int, withBranches bool) ([]*types.Header, []*types.Header) { | ||
| previousHash := blockState.BestBlockHash() | ||
|
|
||
| branches := []testBranch{} |
There was a problem hiding this comment.
var (
currentChain, branchChains []*types.Header
branches []testBranch
)
dot/network/test_helpers.go
Outdated
| @@ -134,7 +134,7 @@ func (s *testStreamHandler) writeToStream(stream libp2pnetwork.Stream, msg Messa | |||
|
|
|||
| func (s *testStreamHandler) readStream(stream libp2pnetwork.Stream, peer peer.ID, decoder messageDecoder, handler messageHandler) { | |||
| var ( | |||
| maxMessageSize uint64 = maxBlockResponseSize // TODO: determine actual max message size | |||
| maxMessageSize uint64 = maxBlockResponseSize | |||
There was a problem hiding this comment.
msgBytes := make([]byte, maxBlockResponseSize)
dot/rpc/modules/state.go
Outdated
| return nil | ||
| } | ||
|
|
||
| for _, key := range keys { |
There was a problem hiding this comment.
*res = make([]interface{}, 0, len(keys))
dot/types/extrinsic.go
Outdated
Comment on lines
76
to
80
| err = decoder.Decode(&e.Version) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
return decoder.Decode(&e.Version)
arijitAD
approved these changes
Oct 13, 2021
EclesioMeloJunior
approved these changes
Oct 15, 2021
lib/runtime/wasmer/imports.go
Outdated
| @@ -661,7 +661,7 @@ func ext_crypto_sr25519_verify_version_1(context unsafe.Pointer, sig C.int32_t, | |||
|
|
|||
| if ok, err := pub.VerifyDeprecated(message, signature); err != nil || !ok { | |||
| logger.Debug("[ext_crypto_sr25519_verify_version_1] failed to validate signature", "error", err) | |||
| // TODO: fix this, fails at block 3876 | |||
| // Tthis fails at block 3876, which seems to be expected, based on discussions | |||
There was a problem hiding this comment.
Suggested change
| // Tthis fails at block 3876, which seems to be expected, based on discussions | |
| // This fails at block 3876, which seems to be expected, based on discussions |
Codecov Report
@@ Coverage Diff @@
## development #1876 +/- ##
===============================================
- Coverage 59.72% 59.60% -0.13%
===============================================
Files 187 187
Lines 19185 19110 -75
===============================================
- Hits 11458 11390 -68
- Misses 5819 5825 +6
+ Partials 1908 1895 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues
TODOComments from Code #1846Primary Reviewer