chore (pkg/scale): Integrate scale into lib/genesis #1663
Conversation
jimjbrettj
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
noot and
timwu20
as code owners
jimjbrettj
changed the title
| } | ||
| } | ||
| } | ||
| // |
There was a problem hiding this comment.
why is this all commented out?
There was a problem hiding this comment.
Was causing a circular dependency issue so I commented out for now and Tim said he would need to revise the package for this test
| if i == nil { | ||
| err = fmt.Errorf("uint128 is nil: %v", i) | ||
| return | ||
| } |
There was a problem hiding this comment.
thought this would be handled higher up - @timwu20 is this needed?
There was a problem hiding this comment.
It might not be. I added because when I was initially encoding with the old AccountInfo type there were cases where the fields weren't initialized and it was crashing. Shouldn't be an issue now since I changed that but I kept this anyways. Can remove if not necessary
There was a problem hiding this comment.
I don't think this should be necessary. In most use cases when encoding, you would've have initialised a value for that pointer, instead of a zero case pointer. Nevertheless, it shouldn't panic in the event a zero case pointer is passed in. Can you point me to the code that causes this panic?
There was a problem hiding this comment.
Yeah dot/rpc/modules/system_test.go where the AccountInfo type was used the struct fields weren't initiated and thats what caused my initial issue. This pr changed it so now they are initialized now
* refactor telemetry messages to map format
* add basic network state telemetry message
* refactor message sender to handle interface{} types
* refactor telemetry messages to be structs
* lint
* go fmt
* lint
* move msg building logic outside msg sending loop
* make telemetry messages an interface
* Lookup transactions count from TransactionsState
* address comments
* fix mocks for tests
* lint
* refactor TelemetryMessage to Message
* update mock handler to return result
* add TransactionsCount to mockhandler
* move logic to build new network state message
* lint
* fix interface
* update mockhandler
* lint
…gossamer into jimmy/scale-integrate-genesis
Changes
Tests
Issues