fix lint

ChainSafe · Nov 3, 2021 · 6cc0264 · 6cc0264
1 parent 54879ba
commit 6cc0264
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/dot/core/service.go b/dot/core/service.go
@@ -324,7 +324,6 @@ func (s *Service) handleBlocksAsync() {
 			}
 
 			s.maintainTransactionPool(block)
-
 		case <-s.ctx.Done():
 			return
 		}

diff --git a/lib/runtime/test_helpers.go b/lib/runtime/test_helpers.go
@@ -89,9 +89,6 @@ func GetRuntimeBlob(testRuntimeFilePath, testRuntimeURL string) (n int64, err er
 	if err != nil {
 		return 0, err
 	}
-	defer func() {
-		_ = out.Close()
-	}()
 
 	/* #nosec */
 	resp, err := http.Get(testRuntimeURL)
@@ -103,7 +100,15 @@ func GetRuntimeBlob(testRuntimeFilePath, testRuntimeURL string) (n int64, err er
 	}()
 
 	n, err = io.Copy(out, resp.Body)
-	return n, err
+	if err != nil {
+		return 0, err
+	}
+
+	if err = out.Close(); err != nil {
+		return 0, err
+	}
+
+	return n, nil
 }
 
 // TestRuntimeNetwork ...

diff --git a/scripts/install-lint.sh b/scripts/install-lint.sh
@@ -6,7 +6,7 @@ fi
 
 if ! command -v golangci-lint &> /dev/null
 then
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.41.0
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.43.0
 fi
 
 export PATH=$PATH:$(go env GOPATH)/bin
-Original file line number
+Diff line change
@@ Expand Up / @@ -324,7 +324,6 @@ func (s *Service) handleBlocksAsync() { @@
     			}
     			s.maintainTransactionPool(block)
     		case <-s.ctx.Done():
     			return
     		}
@@ Expand Down @@