Decode method -> DecodeVersion function

lib/runtime/version.go

@@ -54,39 +54,35 @@ func (v *Version) Encode() (encoded []byte, err error) {
 	return scale.Marshal(toEncode)
 }
 
-// Decode scale decodes the encoded version data and returns an error.
+// DecodeVersion scale decodes the encoded version data and returns an error.
 // It first tries to decode the data using the current version format.
 // If that fails with an EOF error, it then tries to decode the data
 // using the legacy version format (for Kusama).
-func (v *Version) Decode(encoded []byte) (err error) {
-	var newVersionData Version
-	err = scale.Unmarshal(encoded, &newVersionData)
+func DecodeVersion(encoded []byte) (version Version, err error) {
+	err = scale.Unmarshal(encoded, &version)
 	if err == nil {
-		*v = newVersionData
-		return nil
+		return version, nil
 	}
 
 	if !strings.Contains(err.Error(), "EOF") {
 		// TODO io.EOF should be wrapped in scale
-		return err
+		return version, err
 	}
 
 	// TODO: kusama seems to use the legacy version format
 	var legacy legacyData
 	err = scale.Unmarshal(encoded, &legacy)
 	if err != nil {
-		return fmt.Errorf("decoding legacy version: %w", err)
+		return version, fmt.Errorf("decoding legacy version: %w", err)
 	}
 
-	*v = Version{
+	return Version{
 		SpecName:         legacy.SpecName,
 		ImplName:         legacy.ImplName,
 		AuthoringVersion: legacy.AuthoringVersion,
 		SpecVersion:      legacy.SpecVersion,
 		ImplVersion:      legacy.ImplVersion,
 		APIItems:         legacy.APIItems,
 		legacy:           true,
-	}
-
-	return nil
+	}, nil
 }

lib/runtime/version_test.go

@@ -91,8 +91,7 @@ func Test_VersionData_Scale(t *testing.T) {
 			require.NoError(t, err)
 			require.Equal(t, testCase.encoding, encoded)
 
-			var decoded Version
-			err = decoded.Decode(encoded)
+			decoded, err := DecodeVersion(encoded)
 			require.NoError(t, err)
 
 			assert.Equal(t, testCase.decoded, decoded)

lib/runtime/wasmer/exports.go

@@ -37,9 +37,9 @@ func (in *Instance) Version() (version runtime.Version, err error) {
 		return version, err
 	}
 
-	err = version.Decode(res)
+	version, err = runtime.DecodeVersion(res)
 	if err != nil {
-		return version, fmt.Errorf("decoding: %w", err)
+		return version, fmt.Errorf("decoding version: %w", err)
 	}
 
 	return version, nil