-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify module tsc option #5099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing it was caused by this change: #5091
It seems the scope of this docs check is insufficient. Please add /docs
path to the workflow, or I can do it in a subsequent PR.
docs/tsconfig.json
Outdated
@@ -3,6 +3,7 @@ | |||
"extends": "@tsconfig/docusaurus/tsconfig.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"extends": "@tsconfig/docusaurus/tsconfig.json", | |
"extends": "@docusaurus/tsconfig", |
You will need to install this: yarn add --dev
@docusaurus/tsconfig`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, the lock file looks quite different now. Could that be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is expected, shouldnt be an issue
Summary of changes
Changes introduced in this pull request:
compilerOptions.module
to"Node16"
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist