Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show watch indicator #472

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Show watch indicator #472

merged 2 commits into from
Jan 8, 2024

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jan 8, 2024

closes #176

Not 100% convinced as this kinds of hides a good part of the identicon.. but on the other hand, we're talking about watched accounts.. so it's not that important.

image
image


Submission checklist:

Layout

  • Change inspected in the desktop web ui
  • Change inspected in the mobile web ui

Compatibility

  • Functionality of change validated with a connected account with multisig
  • Looks good for solo multisig
  • Looks good for multisig with proxy

@asnaith
Copy link
Contributor

asnaith commented Jan 8, 2024

Looking good mostly but I found a problem where the "eye" badge from a watched account disappears once you connect a wallet that is a member of a pure.

badge.mp4

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jan 8, 2024

This is actually expected. The moment you connect an account that is a signatory, the multi/proxy is not considered as "view only" any more, and that's when you get the "new transaction" button, the ability to "review" txs etc. The only issue I see here, is that the account in the watch list becomes irrelevant, but there's not much we can do.

Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't connecting with the account that was being watched...but it was part of the same multisig, so this would be intentional behaviour.

So, this looks good to go! Thanks for adding the tests too :)

@Tbaut Tbaut merged commit 52b663f into main Jan 8, 2024
7 checks passed
@Tbaut Tbaut deleted the tbaut-watched-indicator branch January 8, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate between owned and watched accounts in drop down selector
2 participants