Differenciate desktop and mobile to clean up tests #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lykhoyda
reviewed
Dec 12, 2023
| @@ -27,7 +28,7 @@ const isOptionEqualToValue = (option?: MultiProxy, value?: MultiProxy) => { | |||
| return option.multisigs[0].address === value.multisigs[0].address | |||
| } | |||
|
|
|||
| const MultiProxySelection = ({ className }: Props) => { | |||
| const MultiProxySelection = ({ className, isDesktop }: Props) => { | |||
There was a problem hiding this comment.
I would probably use the hook, to avoid passing the props to the component. F.e
const isDesktop = useMediaQuery((theme: Theme) => theme.breakpoints.up('md'))There was a problem hiding this comment.
I don't think this hook should be used here. At the end of the day, it's just a testId to identify the specific MultiProxySelection component. The fact that we're using it for dektop or mobile is not relevant.
I'll rename it in testId.
Lykhoyda
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #447
Submission checklist:
Layout