-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Align the delete icon for change mutisig modal #451
Conversation
Looking great except for the small device / margin issue which Thibaut already mentioned. I'm guessing the screenshot below is also the same / similar issue? Here the last two are not in alignment although they don't break out of the parent (this is the "Pixel 7" layout in dev tools). I really like the new hover highlighting the entire row, that's a good visual tweak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great now, thank you!
A couple notes for the PR
- please remove the checkboxes in the first post if you think they don't apply, so that we don't see them as a "todo" from the implementer that aren't done yet
- regarding the mobile view, this checkbox is exactly there for the reason that implementers should remember to check some of the smallest recent phones, such as the iphones SE. We of course don't want to support every single mobile phone.
@Lykhoyda Yep, I've re-tested with the latest version of code and all looking great now :) |
closes #194
Submission checklist:
Layout
Compatibility