Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: menu jump during multisig switch #449

Merged
merged 9 commits into from
Dec 5, 2023
Merged

fix: menu jump during multisig switch #449

merged 9 commits into from
Dec 5, 2023

Conversation

Lykhoyda
Copy link
Collaborator

@Lykhoyda Lykhoyda commented Dec 1, 2023

closes #387

  • Fixes UI jump during multisig switch
  • The loader is not shown anymore for the multiproxy selector
  • Overview page has loading status during multisigs fetching

Submission checklist:

Layout

  • Change inspected in the desktop webUIi
  • Change inspected in the mobile webUIi

Compatibility

  • Functionality of change validated with a connected account with multisig
  • Applicable elements hidden/disabled for watched multisigs / pure
  • Looks good for solo multisig
  • Looks good for multisig with proxy

@Lykhoyda Lykhoyda requested review from Tbaut and asnaith December 1, 2023 14:46
Tbaut
Tbaut reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks a lot. Just some nits to keep the convention we have to use testId for re-used components.

packages/ui/src/components/LoadingBox.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/LoadingBox.tsx Outdated Show resolved Hide resolved
packages/ui/src/hooks/useDisplayLoader.tsx Outdated Show resolved Hide resolved
asnaith
asnaith approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look at it, I was awaiting the latest code changes after Thibaut's review before testing it.

It looks good to merge after the testID convention updates :)

This is a nice improvement, especially for mobile view

@Lykhoyda Lykhoyda requested a review from Tbaut December 5, 2023 11:07
Tbaut
Tbaut approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@Tbaut Tbaut merged commit 1d13ff2 into main Dec 5, 2023
6 checks passed
@Tbaut Tbaut deleted the lykhoyda/fix_menu_jump branch December 5, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jumping/flashing issues in menu bar
3 participants
@Lykhoyda @asnaith @Tbaut