-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to init the wallet with a predefined allowed origin #448
Conversation
As the setup is done before the visit perhaps we could name it this way around?
|
That failing test is annoying. I can reproduce locally, and it sounds like it's actually a bug, but it's not happening in prod, |
Agree, we need to come up with a better name for visitCustom method. Maybe |
setupAndVisit it is :) Looks good to go |
ah I wrote a comment the other day, at least I thought, but didn't click and commit. I went for now weirdly the test that used to fail is passing... 🙄 if it proves annoying in the future I'll just take another look at it, but it sounded a little like an annoying edge case specific to the test. |
I just had to name it for it to fail. I'll take a look then, before merging. |
closes #433
This allows to reduce a lot of the clicks to connect etc if not needed. Users once they've allowed a website to access their accounts will not have to authorize the connection every single time. This is what this feature enables.
The
visitWithLocalStorage
function which was used all over, now must have a new name. Please suggest anything better if you thinkvisitCustom
isn't great. The reason why I had to bloat it, is because the extension and the accounts need to be loaded in the window object before the page loads, which is also when we set the custom localStorage elements 🤷♂️