Support Joystream #437
Support Joystream #437
Conversation
There was a problem hiding this comment.
Looking good for the most part, I was able to create a multisig (without proxy as it says proxies are not supported on Joystream) and send a tx.
However, there is an app crash if you try to set identity either from the options menu on the main page or the set identity dropdown on the "Send tx" modal.
|
Great find. I guess they don't have the identity pallet as well, and Multix assumes it's there. I'll fix, and add a test. |
|
Aaaand finally fixed the tests! |
| when?: MultisigStorageInfo['when'] | ||
| } | ||
| export const getAsMultiTx = ({ api, threshold, otherSignatories, tx, weight, when }: Params) => { | ||
| return api.tx.multisig.asMulti.meta.args.length === 6 |
There was a problem hiding this comment.
Can we make a "6" a constant that will describe itself? as it looks as magic number now :)
There was a problem hiding this comment.
Good point, it is indeed a magic number as it's actually not future proof. Unfortunately we have no other choice afaik (I took this idea from the pjs/apps code). Joystream will migrate in the next months, and we can eventually remove this "if". I'll make this a constant such as PARAM_LENGTH_OLD_ASMULTI
closes #438
Submission checklist:
Layout
Compatibility