-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of CAIP-2 for EOSIO blockchains #33
Conversation
…EOSIO implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add your CAIP to the list in the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM - but would love some more eye-ballz on it before the merge @pedrouid @webmaster128 @rekmarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and this conflicts with https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-2.md#syntax. The reference part must not exceed 47 characters, which is why we use prefixes in https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-4.md
The alternative to prefixes is to use a different encoding for the 32 bytes. CAIP-2 is case-sensitive and you need 32/47 = 68% efficiency. So candidates are Base58 or Base62 (no idea how this encoding works but promising in theory). However, I think it is easier for human consumption to use a prefix of the default encoding than to re-encode it. |
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
…to use a prefix of the chain ID
I've updated the reference definition, to use a 32 character prefix of the Chain ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some wording 💅 but otherwise 👍
Co-authored-by: Simon Warta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool and welcome
Great! Thanks! |
@ligi can we merge this? I don't have permissions to do so. |
Initial draft of the CAIP-2 for EOSIO blockchains.