Update triangulation algorithm (1.0) #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I was able to convert the obj model to a glTF 1.0 and view it with the model inspector. Looks same as in the correct version in #157. Tests are also all passing locally. Travis seems to be failing because it's running with an older version of Node that doesn't support the spread |
lilleyse
force-pushed
the
fix-triangulation-1.0
branch
2 times, most recently
from
39cea21 to
57a9baf
Compare
|
Thanks @OmarShehata. Fixed the travis build in #159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #157 but for the 1.0 branch.
@OmarShehata could you test? The changes should be basically the same as #157.