Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ambient texture if it is the same as the diffuse texture #127

Merged
merged 3 commits into from
Jan 29, 2018
Merged

Ignore ambient texture if it is the same as the diffuse texture #127

merged 3 commits into from
Jan 29, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jan 19, 2018 •
edited
Loading

OBJ models are often exported with the same texture in the diffuse and ambient slots but this is typically not desirable, particularly when saving with PBR materials where the ambient texture is treated as the occlusion texture.

@shehzan10
Copy link
Member

@lilleyse Can you resolve the conflict? I'll merge it after that.

@lilleyse
Copy link
Contributor Author

@shehzan10 Updated.

@shehzan10 shehzan10 merged commit dc2196e into master Jan 29, 2018
@shehzan10 shehzan10 deleted the diffuse-ambient branch January 29, 2018 14:43
lilleyse added a commit that referenced this pull request Nov 1, 2018
@lilleyse
Port over #127
ade20d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shehzan10 shehzan10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilleyse @shehzan10