Web3d quantized attributes #56
Conversation
…ne into web3d-quantized-attributes
|
I'll do a first review here since I have also been looking at CesiumGS/cesium#3891, but @lilleyse can you please do the final review and merge? |
|
@JoshuaStorm @likangning93 can you make a new branch and include this in your interface? |
|
|
||
| module.exports = getBinaryGltf; | ||
|
|
||
| function getBinaryGltf(gltf, callback) { |
There was a problem hiding this comment.
Are there unit tests for this?
There was a problem hiding this comment.
There are unit tests for writeBinaryGltf which uses this directly.
There was a problem hiding this comment.
Sounds good, can you double check the coverage and update if needed?
|
Just those comments from me. This might also need more unit tests. |
Yes, it definitely needs more robust testing |
| var writeSource = require('./writeSource'); | ||
| var mergeBuffers = require('./mergeBuffers'); | ||
| var removePipelineExtras = require('./removePipelineExtras'); | ||
| var getBinaryGltf = requilre('./getBinaryGltf'); |
There was a problem hiding this comment.
Whoops, yes that's a typo
|
@pjcozzi I think I hit everything here. Fixing removeUnusedVertices will be part of a separate pull request; it's outside the scope of these changes. |
…ne into web3d-quantized-attributes
…ne into web3d-quantized-attributes
| @@ -18,7 +18,8 @@ if (process.argv.length < 3 || defined(argv.h) || defined(argv.help)) { | |||
| ' -i, input=PATH Read unoptimized glTF from the specified file.\n ' + | |||
| ' -o, output=PATH write optimized glTF to the specified file.\n' + | |||
| ' -b, write binary glTF file.\n' + | |||
| ' -s, writes out separate geometry/animation data files, shader files and textures instead of embedding them in the glTF file.\n '; | |||
| ' -s, writes out separate geometry/animation data files, shader files and textures instead of embedding them in the glTF file.\n' + | |||
| ' -q, quantize the attributes of this model.\n'; | |||
There was a problem hiding this comment.
Also update README.md please.
|
Just those trivial comments. Looking forward to merging this! |
|
Updated. |
|
Awesome! |
Adds support for quantized attributes.
Related to #308