Fixed additive refinement traversal bug #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks OK. Could be worth adding a comment why additive always loads the tile. @ggetz could you please test this? |
|
Yep, looks like it's working! We may want to also update the thumbnail for the example, since it shows the initial view where not all the building are loaded. |
|
Updated thumbnail |
|
@pjcozzi This should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5766
This fixes an issue exclusive to additive refinement and with
skipLevelOfDetailset to true (default).Tiles with additive refinement were not getting loaded unless they were leaf tiles or they couldn't refine to their children due to SSE. Many interior tiles did not fit this condition and were never loaded. This fix forces additive tiles to always load during the traversal.