Closes issue #5691 #5699
Closed
Closes issue #5691 #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is about fixing safari crash on mouse move because of using replaceState to often. There was a syntax error in using setTimeout function where interval value was on the third place in func parameters list when it should be on second.
Some fixes to previous commit as @hpinkos recommended Replaced eventListener moveStart / moveEnd with Camera.changed event listener. Replaced setInterval with setTimeout function in that event.
Set 'updateTimer = undefined' after 'clearTimeout(updateTimer)' call
|
@avalan4e57 can you please send us a Contributor's License Agreement so we can review and merge this? See https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla |
|
@hpinkos done! |
|
@hpinkos I’ve thought a little about it. And came to conclusion that I don’t want to contribute to AGI projects. Either I get paid for my code or I have my rights on it. Thank you for understanding and sorry for waisting your time. |
|
No worries @avalan4e57! Thanks for considering to support the project, we hope you are having great success with your development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.