Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a link to gltf-vscode to VSCode Guide #5293

Merged
merged 4 commits into from
May 10, 2017
Merged

Added a link to gltf-vscode to VSCode Guide #5293

merged 4 commits into from
May 10, 2017

Conversation

ryki2658
Copy link
Contributor

@ryki2658 ryki2658 commented May 9, 2017

added a brief description and link to gltf-vscode

@emackey
Copy link
Contributor

emackey commented May 9, 2017

Can this be added as an additional bullet point under "VSCode Plugins (mostly optional)" instead of a whole new section at the end? Thanks!

Also... while you're at it, please rename "VSCode Plugins (mostly optional)" to "VSCode Extensions (mostly optional)". My mistake originally.

@emackey
Copy link
Contributor

emackey commented May 9, 2017

Actually change "plugins" to "extensions" throughout for that. Thanks!

@pjcozzi
Copy link
Contributor

pjcozzi commented May 9, 2017

@ryki2658 it is great to see you contributing here as well as gltf-pipeline!

Could you please also add yourself to CONTRIBUTORS.md in this branch?

@pjcozzi
Copy link
Contributor

pjcozzi commented May 10, 2017

Fixes #5137

@ryki2658
Copy link
Contributor Author

ryki2658 commented May 10, 2017

Ok I added myself CONTRIBUTORS.md and made the appropriate changes to the file. Please let me know if there are any other modifications I should make.

@emackey
Copy link
Contributor

emackey commented May 10, 2017

Awesome, thanks @ryki2658.

@emackey emackey merged commit 29d9d29 into CesiumGS:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants