-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to CLAs #5177
Fix link to CLAs #5177
Conversation
@@ -0,0 +1,147 @@ | |||
Analytical Graphics, Inc. | |||
Software Grant and Corporate Contributor License Agreement ("Agreement") | |||
http://www.agi.com/licenses/corporate-cla-agi-v1.0.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the URL that no longer works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh whoops. Good eye @emackey! I'll fix that in master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new URL is really long and overruns the line width we use in the rest of the file....
Should I add a line break in the url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried this, but maybe worth a shot: https://github.com/blog/985-git-io-github-url-shortener
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw that too. I wasn't sure if it'd be acceptable to use a URL shortener.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making a new CLA repo (or something similar) and using github pages. Result could be something like:
https://analyticalgraphicsinc.github.io/CLA/individual-cla-agi-v1.0.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea since the CLA is shared among all AGI repos, not just Cesium.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are evaluating lots of CLA ideas so please hold on the new repo, just removing the link would be OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new AGI website, the links to the CLAs no longer worked. I moved them to this repo for easier maintenance.