Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to CLAs #5177

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Fix link to CLAs #5177

merged 1 commit into from
Apr 3, 2017

Conversation

pjcozzi
Copy link
Contributor

@pjcozzi pjcozzi commented Apr 3, 2017

With the new AGI website, the links to the CLAs no longer worked. I moved them to this repo for easier maintenance.

@hpinkos hpinkos merged commit 9368a1d into master Apr 3, 2017
@hpinkos hpinkos deleted the clas branch April 3, 2017 19:38
@@ -0,0 +1,147 @@
Analytical Graphics, Inc.
Software Grant and Corporate Contributor License Agreement ("Agreement")
http://www.agi.com/licenses/corporate-cla-agi-v1.0.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the URL that no longer works?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops. Good eye @emackey! I'll fix that in master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new URL is really long and overruns the line width we use in the rest of the file....
Should I add a line break in the url?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried this, but maybe worth a shot: https://github.com/blog/985-git-io-github-url-shortener

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I saw that too. I wasn't sure if it'd be acceptable to use a URL shortener.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making a new CLA repo (or something similar) and using github pages. Result could be something like:

https://analyticalgraphicsinc.github.io/CLA/individual-cla-agi-v1.0.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea since the CLA is shared among all AGI repos, not just Cesium.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are evaluating lots of CLA ideas so please hold on the new repo, just removing the link would be OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpinkos hpinkos mentioned this pull request Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants