Vector tiles polylines #4208
Vector tiles polylines #4208
Conversation
| PolylineColorAppearanceVS, | ||
| BlendingState, | ||
| Pass | ||
| ) { |
There was a problem hiding this comment.
Formatting
Pass) {
'use strict';
|
Looks good so far. How easy would it be to support dynamic width? |
|
I set the width to 10 and am seeing some artifacts. Is this already considered as part of your to-do list? |
|
Added to tasklist:
|
| @@ -0,0 +1,418 @@ | |||
| /*global define*/ | |||
| define([ | |||
There was a problem hiding this comment.
Should we rename this class to something more generic in case it is used for other batched renderers?
There was a problem hiding this comment.
This organization would be similar to instanced models.
As discussed offline at one point, I think it is fine to have |
| shaderProgram : primitive._sp, | ||
| uniformMap : uniformMap, | ||
| boundingVolume : primitive._boundingVolume, | ||
| modelMatrix : Matrix4.IDENTITY, |
|
Just those comments. |
…of batch ids for polygons.
As part of this PR? Or in a separate PR to master? |
It should be pretty easy. I want to add it to the batch table instead of having it as a vertex attribute. |
|
I'm going to merge this into the |
If this needs to be done for vector tiles, I would like to have this PR go into master so it doesn't still in |
For CesiumGS/3d-tiles#25.
This is a branch off
vector-tiles-polygonsso I opened a PR into that to minimized the code diff. Either wait until both this and #4186 are ready or I can open a new PR intovector-tiles.GROUNDpass?