Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated OpenStreetMapImageryProvider #3421

Merged
merged 3 commits into from
Jan 14, 2016
Merged

Deprecated OpenStreetMapImageryProvider #3421

merged 3 commits into from
Jan 14, 2016

Conversation

TomPed
Copy link
Contributor

@TomPed TomPed commented Jan 13, 2016

Removed OpenStreetMapImageryProvider and OpenStreetMapImageryProviderSpec.

For #3222

@lilleyse
Copy link
Contributor

Update CHANGES.md and add a breaking change for OpenStreetMapImageryProvider. Look at the listing under 1.17 as an example.

@TomPed
Copy link
Contributor Author

TomPed commented Jan 13, 2016

Updated.

lilleyse
lilleyse reviewed Jan 13, 2016
View reviewed changes
CHANGES.md
@@ -8,6 +8,9 @@ Change Log

### 1.18 - 2016-02-01

* Breaking changes
* Removed `OpenStreetMapImageryProvider`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In following the others, just add another sentence: "Use createOpenStreetMapImageryProvider instead."
Also remove the white space.

@TomPed
Copy link
Contributor Author

TomPed commented Jan 13, 2016

Updated.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 13, 2016

@TomPed when you open a pull request, please link to the issue (#3222 in this case) in the description. For more details on opening a PR, see https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#opening-a-pull-request

lilleyse added a commit that referenced this pull request Jan 14, 2016
@lilleyse
Merge pull request #3421 from TomPed/OpenStreetMapImageryProvider-dep…
b057c61 
…recation

Deprecated OpenStreetMapImageryProvider
@lilleyse lilleyse merged commit b057c61 into CesiumGS:3d-tiles Jan 14, 2016
@lilleyse lilleyse deleted the OpenStreetMapImageryProvider-deprecation branch January 14, 2016 13:50
@lilleyse
Copy link
Contributor

Merged.

@TomPed TomPed mentioned this pull request Apr 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomPed @lilleyse @pjcozzi