Adding CZML Examples #3050

sen-lu · 2015-09-29T14:56:02Z

in reference to #3027

…nto czml-examples added CZML path example

…-examples merge

pjcozzi · 2015-09-29T14:59:58Z

Thanks @TiffanyLu and @adamdavidcole. We'll do a quick review now.

pjcozzi · 2015-09-29T15:01:22Z

Were you able to push the build directory to your gh-pages branch? If so, can you provide a link to Sandcastle so we can share the new CZML examples for community feedback?

pjcozzi · 2015-09-29T15:04:44Z

There is one JSHint error:

$ ./Tools/apache-ant-1.8.2/bin/ant build jsHint
Buildfile: /Users/pcozzi/source/cesium3/cesium/build.xml

build:

build:

jsHint:
[runJsHint] Checked 50 files
[runJsHint] Checked 100 files
[runJsHint] Checked 150 files
[runJsHint] Checked 200 files
[runJsHint] Checked 250 files
[runJsHint] Checked 300 files
[runJsHint] Checked 350 files
[runJsHint] Checked 400 files
[runJsHint] Checked 450 files
[runJsHint] Checked 500 files
[runJsHint] Checked 550 files
[runJsHint] Checked 600 files
[runJsHint] Checked 650 files
[runJsHint] Checked 700 files
[runJsHint] Checked 750 files
[runJsHint] Checked 800 files
[runJsHint] Checked 850 files
[runJsHint] Checked 900 files
[runJsHint] Errors:
[runJsHint] Apps/Sandcastle/gallery/CZML Points.html: line 29, col 14, Extra comma. (it breaks older versions of IE)

This is why Travis CI failed above: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/82754199

pjcozzi · 2015-09-29T15:07:18Z

Apps/Sandcastle/gallery/CZML Billboard and Label.html

@@ -0,0 +1,80 @@
+<!DOCTYPE html>


Can we update CZML Billboard and Label.jpg so the label is not missing the "A" in "AGI?" Just use Firefox to take the screenshot.

pjcozzi · 2015-09-29T15:09:50Z

Apps/Sandcastle/gallery/CZML Circles and Ellipses.html

+            },
+            {
+                "id" : "Green circle at height",
+                name: "Green circle at height",


Throughout all examples, please use strict JSON so name should be "name". In general, all CZML property names should be strings in double quotes so it is easy to store them as JSON.

Ok, I will go through and fix those.

Once I do, how do I update the pull request?

Thanks,
Adam

On Tue, Sep 29, 2015 at 11:09 AM, Patrick Cozzi [email protected]
wrote:

In Apps/Sandcastle/gallery/CZML Circles and Ellipses.html
#3050 (comment)
:

+
Loading...

+

+
+<script id="cesium_sandcastle_script">

function startup(Cesium) {

"use strict";

//Sandcastle_Begin

var czml = [

{

"id" : "document",

"name" : "CZML Geometries: Circles and Ellipses",

"version" : "1.0"

},

{

"id" : "Green circle at height",

name: "Green circle at height",

Throughout all examples, please use strict JSON so name should be "name".
In general, all CZML property names should be strings in double quotes so
it is easy to store them as JSON.

—
Reply to this email directly or view it on GitHub
https://github.com/AnalyticalGraphicsInc/cesium/pull/3050/files#r40684026
.

emackey · 2015-10-05T14:10:49Z

Hey, this looks pretty cool. Here's a suggestion for code at the bottom of the "CZML Path" demo with the paraglider. This turns on terrain and tracks the entity.

var terrainSources = Cesium.createDefaultTerrainProviderViewModels();
var viewer = new Cesium.Viewer('cesiumContainer', {
    terrainProviderViewModels : terrainSources,
    selectedTerrainProviderViewModel : terrainSources[1]
});
viewer.dataSources.add(Cesium.CzmlDataSource.load(czml)).then(function(ds) {
    viewer.trackedEntity = ds.entities.getById('path');
});

emackey · 2015-10-05T14:16:17Z

Apps/Sandcastle/gallery/CZML Rectangle.html

+      "name" : "rectangle with image, above surface",
+      "rectangle" : {
+        "show" : true,
+        "coordinates" : { "wsenDegrees" : [-75, 40, -65, 50] },


The aspect ratio of the Cesium logo is off by a lot here, can you fix? Try this:

"coordinates" : { "wsenDegrees" : [-75, 40, -50, 45] },

pjcozzi · 2015-10-05T17:53:22Z

@emackey good feedback, thanks. @TiffanyLu @adamdavidcole let's make these changes.

pjcozzi · 2015-10-06T12:47:03Z

@TiffanyLu @adamdavidcole please merge Cesium master into this branch so GitHub will be able to auto merge this pull request.

Right now there is a merge conflict. It is most likely in CHANGES.md and will be easy to resolve. Let me know if you need any help and when this pull request is ready to merge (all feedback addressed and no merge conflict). Thanks!

mramato · 2015-10-06T17:42:36Z

Apps/Sandcastle/gallery/CZML Rectangle.html

+        "fill" : true,
+        "material" : {
+          "image" : {
+            "image" : { "uri" : "https://raw.githubusercontent.com/AnalyticalGraphicsInc/cesium/master/Apps/Sandcastle/images/Cesium_Logo_Color.jpg" }


This should use a relative URL to the local Sandcastle file, not a full URL to GitHub.

…added thumbnail to czml billboard&label

emackey · 2015-10-07T14:14:25Z

Apps/Sandcastle/gallery/CZML Rectangle.html

+        "fill" : true,
+        "material" : {
+          "image" : {
+            "image" : { "uri" : "/Apps/Sandcastle/images/Cesium_Logo_Color.jpg" }


Oh, I don't mean to nit-pick, but this path is still absolute, not relative. Please use a relative path, like this:

"image" : { "uri" : "../images/Cesium_Logo_Color.jpg" }

You'll note the absolute path is not working on tiffanylu.com anyway, because it's deployed to a subfolder. The relative path should fix it there too.

…rvals, availability

pjcozzi · 2015-10-08T17:48:48Z

I removed the extrudedHeight property—do you still get the flicker?

Thanks, I will test tomorrow morning when I have access to Windows. In the meantime, is there anything else this pull request needs before we can merge?

sen-lu · 2015-10-08T23:32:54Z

@pjcozzi nope, we're ready!

pjcozzi · 2015-10-09T13:05:28Z

I removed the extrudedHeight property—do you still get the flicker?

No, it looks good.

pjcozzi · 2015-10-09T13:05:49Z

Thanks again for this contribution, @TiffanyLu and @adamdavidcole!

Adding CZML Examples

mramato · 2015-10-09T13:50:14Z

@TiffanyLu and @adamdavidcole, thanks a lot. These are awesome! I'm sure they will save a lot of users a lot of time.

I know I'm late to the party so I'm going to write up another issue with some suggestions, but it's mostly minor stuff. I'll also include a model example.

mramato · 2015-10-09T14:15:28Z

See #3063

EDIT: I linked to the wrong issue

pjcozzi and others added 23 commits September 13, 2015 11:34

Update CHANGES.md

85154d8

Basic CZML billboard and label example

77b1304

added examples for polyline, rectangle, ellipsoids & polygon

01e7189

added polygon example, amended polygon+time to include perPositionHeight

3069a6d

CZML examples for circles and ellipses

371b7f7

added example of CZML point

467e17c

add images to some of the czml examples

cf89588

added three more images for the CZML examples

8a4bd4f

Added dynamic polygon - interpolation CZML example

c62625b

added CZML dynamic polygon w/ intervals

dae16c8

coord map, point dynamic, wall

59610e2

merge

925c813

tidied up polygon czml examples

1bf509e

dynamic points with radians

fd8609b

fixed point time dynamic czml example

97802e1

added CZML path example

8020e05

Merge branch 'czml-examples' of https://github.com/tiffanylu/cesium i…

3fc8db1

…nto czml-examples added CZML path example

added screenshots

6488fed

Merge branch 'czml-examples' of github.com:tiffanylu/cesium into czml…

909f839

…-examples merge

fixed accidental unstaging of point time dynamic example

6bd7410

fixed misnamed czml doc is

42cbdbd

merge

a1838ef

fixed misnamed ID

e720c47

pjcozzi reviewed Sep 29, 2015
View reviewed changes

removed extra comma

7e7f922

pjcozzi reviewed Sep 29, 2015
View reviewed changes

sen-lu added 3 commits September 30, 2015 00:40

made changes to CZML Rectangle.html

971230e

made changes to CZML Path.html

18d6313

added names and ids to tiff's czml examples

7fc8dd4

emackey reviewed Oct 5, 2015
View reviewed changes

made changes based on pull request comments

da32554

mramato reviewed Oct 6, 2015
View reviewed changes

sen-lu and others added 4 commits October 7, 2015 03:20

made suggested changes in CZML Path and Rectangle

71019a5

removed extrudedheight from czml polygon - interpolating references, …

ccbdf72

…added thumbnail to czml billboard&label

Merge branch 'master' into czml-examples

0b58564

Merge AnalyticalGraphicsInc/cesium/master to czml-examples

3468b5d

pjcozzi mentioned this pull request Oct 7, 2015

CZML Sandcastle examples #3027

Closed

emackey reviewed Oct 7, 2015
View reviewed changes

sen-lu added 3 commits October 8, 2015 13:02

relative path in CZML rectangle

3acd909

removed perPositionHeights from dynamicPolygon in CZML polygon - inte…

3b124b4

…rvals, availability

updated screenshots, standardized formatting across all CZML examples

583fe6a

Tweak points

b8eef71

pjcozzi added a commit that referenced this pull request Oct 9, 2015

Merge pull request #3050 from tiffanylu/czml-examples

249c038

Adding CZML Examples

pjcozzi merged commit 249c038 into CesiumGS:master Oct 9, 2015

pjcozzi deleted the czml-examples branch October 9, 2015 13:05

mramato mentioned this pull request Oct 9, 2015

CZML Example improvements #3063

Closed

11 tasks

sen-lu mentioned this pull request Oct 14, 2015

Czml examples tweaks #3072

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding CZML Examples #3050

Adding CZML Examples #3050

sen-lu commented Sep 29, 2015

pjcozzi commented Sep 29, 2015

pjcozzi commented Sep 29, 2015

pjcozzi commented Sep 29, 2015

pjcozzi Sep 29, 2015

pjcozzi Sep 29, 2015

adamdavidcole Sep 29, 2015

emackey commented Oct 5, 2015

emackey Oct 5, 2015

pjcozzi commented Oct 5, 2015

pjcozzi commented Oct 6, 2015

mramato Oct 6, 2015

emackey Oct 7, 2015

emackey Oct 7, 2015

pjcozzi commented Oct 8, 2015

sen-lu commented Oct 8, 2015

pjcozzi commented Oct 9, 2015

pjcozzi commented Oct 9, 2015

mramato commented Oct 9, 2015

mramato commented Oct 9, 2015

Adding CZML Examples #3050

Adding CZML Examples #3050

Conversation

sen-lu commented Sep 29, 2015

pjcozzi commented Sep 29, 2015

pjcozzi commented Sep 29, 2015

pjcozzi commented Sep 29, 2015

pjcozzi Sep 29, 2015

Choose a reason for hiding this comment

pjcozzi Sep 29, 2015

Choose a reason for hiding this comment

adamdavidcole Sep 29, 2015

Choose a reason for hiding this comment

Loading...

emackey commented Oct 5, 2015

emackey Oct 5, 2015

Choose a reason for hiding this comment

pjcozzi commented Oct 5, 2015

pjcozzi commented Oct 6, 2015

mramato Oct 6, 2015

Choose a reason for hiding this comment

emackey Oct 7, 2015

Choose a reason for hiding this comment

emackey Oct 7, 2015

Choose a reason for hiding this comment

pjcozzi commented Oct 8, 2015

sen-lu commented Oct 8, 2015

pjcozzi commented Oct 9, 2015

pjcozzi commented Oct 9, 2015

mramato commented Oct 9, 2015

mramato commented Oct 9, 2015